chrome-extensions-samples icon indicating copy to clipboard operation
chrome-extensions-samples copied to clipboard

Add a sample of clicking an anchor element with the javascript: scheme

Open daidr opened this issue 2 years ago • 5 comments

Relevant issues: #807 #769

daidr avatar Mar 15 '23 10:03 daidr

@daidr, based on our email discussion would it be reasonable to call this a draft for now? Or would you like a review?

oliverdunk avatar Mar 29 '23 15:03 oliverdunk

@daidr, based on our email discussion would it be reasonable to call this a draft for now? Or would you like a review?

I converted this to draft. Regarding the first issue I mentioned in the email, I tried upgrading Chrome and now the first demo no longer throws errors. However, I cannot pass element objects through events between the main world script and the isolated world script anymore. I will try to find a better way to pass the element that needs to be clicked and rewrite this sample in the next few days.

daidr avatar Mar 29 '23 16:03 daidr

@daidr, thank you for your hard work on this. So that you're not shocked, I want to let you know we will replace your instructions for unpacked loading with a link to ours. Something like this should theoretically included in every README. The problem is that if they ever change the UI for loading unpacked we'll have a maintenance problem on our hands.

jpmedley avatar Mar 29 '23 16:03 jpmedley

@daidr, thank you for your hard work on this. So that you're not shocked, I want to let you know we will replace your instructions for unpacked loading with a link to ours. Something like this should theoretically included in every README. The problem is that if they ever change the UI for loading unpacked we'll have a maintenance problem on our hands.

I understand. What do I need to do?

daidr avatar Mar 29 '23 17:03 daidr

Just remove the loading instructions.

jpmedley avatar Mar 30 '23 13:03 jpmedley