chrome-extensions-samples icon indicating copy to clipboard operation
chrome-extensions-samples copied to clipboard

A CI to check for grammer mistake in the `.md` files

Open ibishal opened this issue 2 years ago • 8 comments

Describe the bug We need to set up a GitHub Actions workflow to automatically check for grammar mistakes in our Markdown (.md) files. This will help ensure that our documentation and other textual content are clear and error-free.

Expected behavior The CI should check for grammatical errors

Notes Anything additional here. 🌈

ibishal avatar Feb 27 '24 14:02 ibishal

Would love to work on this

Gmin2 avatar Feb 27 '24 14:02 Gmin2

would also love to work on this.

obamwonyi avatar Feb 28 '24 12:02 obamwonyi

@oliverdunk I like this idea, but I would like to see what rules this CI tries to enforce. We have to follow the Google style guide. Since style guides can vary, I want to make sure this doesn't just generate a lot of spam that we wouldn't be able follow.

jpmedley avatar Feb 28 '24 17:02 jpmedley

There's also a potential problem that we would always be asking external contributors to change things that the CI asked to do. This scenario creates more work for all of us.

jpmedley avatar Feb 28 '24 17:02 jpmedley

Yeah, following Joe's comment it would be nice if anyone wanting to work on this could propose a specific way they will approach it. For example, the libraries or style rules you intend to use.

oliverdunk avatar Feb 29 '24 10:02 oliverdunk

Yeah, following Joe's comment it would be nice if anyone wanting to work on this could propose a specific way they will approach it. For example, the libraries or style rules you intend to use.

I was exploring and was thinking of using run check

Gmin2 avatar Feb 29 '24 10:02 Gmin2

I was exploring and was thinking of using run check

At a glance, that looks like something that would be likely to fall into the traps Joe mentioned (being too noisy, and not being setup for our specific style guide). I think the most interesting thing here would be definite spelling mistakes but I'm not sure that library supports that?

oliverdunk avatar Feb 29 '24 15:02 oliverdunk

Hey @oliverdunk i think this would fit it (codespell-action

Gmin2 avatar Feb 29 '24 15:02 Gmin2

I'm going to go ahead and close this one. I really appreciate the enthusiasm to help, but I don't think this is something we need right now. I worry about the CI being too noisy / unspecific and this doesn't solve a problem we are too worried about today.

oliverdunk avatar Sep 12 '24 13:09 oliverdunk