accessibility-developer-tools
accessibility-developer-tools copied to clipboard
adds selectors to the Audit results
This adds an additional field to the Audit results object which provides an array of selectors that were found. I added it as an additional field to maintain backwards-compatibility with previous versions.
Some use-cases for adding selectors:
- running audits as a part of unit/integration tests could use the selector to provide a more helpful message (see electron/spectron#126)
- tools like electron/devtron#87 could use the selector directly to
inspect(...)an element when clicked
Questions
- Since
getQuerySelectorText(element)does not always generate a valid selector, should it be configured in theAuditConfigvia something likeconfig.includeSelectors = true? - Oh dear, it looks like Google forgot that I signed the CLA; how should I proceed?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.