headscale-admin icon indicating copy to clipboard operation
headscale-admin copied to clipboard

CreateNode don't need to add nodekey

Open echizenryoma opened this issue 1 year ago • 1 comments

headscale v0.23.0-alpha5 createNode prefix change to mkey

echizenryoma avatar Mar 09 '24 01:03 echizenryoma

Good addition! Since I am still trying to support at least the current stable version, I can't outright remove that code. However, I do have a checkbox on the settings page to use legacy API so I can say if that box is checked, THEN add the nodekey: prefix.

I guess, with this in mind, what I would ask is whether or not it is ALLOWED to have that prefix. If it is permitted, then I am ok leaving it as is until 0.23 is stable. If it needs to be omitted/stripped or changed to mkey:, then I will add that logic in only when using the new 0.23 API (i.e. when the legacy API checkbox is not checked).

Great note, though!

GoodiesHQ avatar Mar 11 '24 07:03 GoodiesHQ