GoodDAPP icon indicating copy to clipboard operation
GoodDAPP copied to clipboard

Error: Failed with last error

Open sentry-io[bot] opened this issue 1 year ago • 10 comments

We got 100ks of such errors. To reduce it we should modify multihttpprovider to keep cycling with RPCs. Perhaps cycle twice through RPCs before reporting an error

Sentry Issue: GOODDAPP-193NG

Error: Failed with last error
  at <object>.value (lib/analytics/AnalyticsClass.js:474:30)
  at call (lib/analytics/AnalyticsClass.js:169:48)
  at formatter (lib/logger/js-logger.js:21:15)
  at logHandler (lib/logger/js-logger.js:33:3)
  at <anonymous> (lib/wallet/MultipleHttpProvider.js:53:11)
...
(3 additional frame(s) were not displayed)

sentry-io[bot] avatar Dec 24 '23 08:12 sentry-io[bot]

@johnsmith-gooddollar we are prioritizing this for sprint 6 - can you confirm you are accountable and will own this ticket?

decentralauren avatar Jan 09 '24 14:01 decentralauren

hot fixed https://github.com/GoodDollar/GoodDAPP/commit/d7d518a070ec6a1271823c7f8a83e8871da47a9e

johnsmith-gooddollar avatar Jan 16 '24 19:01 johnsmith-gooddollar

default retry 1 will mean it will do 2 cycles through rpcs? @johnsmith-gooddollar

sirpy avatar Jan 18 '24 09:01 sirpy

@sirpy yes

johnsmith-gooddollar avatar Jan 18 '24 09:01 johnsmith-gooddollar

@vldkhh @sirpy @johnsmith-gooddollar there are still 220k+ events shown, 30k in last 24 hours. https://gooddollar.sentry.io/issues/4555924288/?notification_uuid=f9bb14b3-15e3-4160-ae50-9bf72133085d&project=1829798&referrer=weekly_report

There is above one: Failed with last error (nothing extra) And there are now new ones: Failed with last error:Network error on rpc X

I think there is still something that needs to be changed or fixed here?

L03TJ3 avatar Feb 12 '24 04:02 L03TJ3

@L03TJ3 yes we still have too many errors logged. see #4215 for improvements

sirpy avatar Feb 12 '24 07:02 sirpy

@vldkhh this just got hotfixed released

L03TJ3 avatar Feb 13 '24 05:02 L03TJ3

@L03TJ3 I don't see this error happening on 2.34.3 env, i think we need some time to monitor it. Currently we have 19k/day

vldkhh avatar Feb 14 '24 15:02 vldkhh

@L03TJ3 need to rechecked - https://gooddollar.sentry.io/issues/4555924288/?project=1829798&referrer=github_integration

vldkhh avatar Feb 23 '24 12:02 vldkhh

@vldkhh Can this be rechecked and if done closed? there is a new issue created for: Failed with last error: unknown --> https://github.com/GoodDollar/GoodDAPP/issues/4230

L03TJ3 avatar Mar 01 '24 08:03 L03TJ3

verified on prod image.png

vldkhh avatar Apr 11 '24 15:04 vldkhh