GoodDAPP icon indicating copy to clipboard operation
GoodDAPP copied to clipboard

Published 20 hours ago • verified publisher icon GoodDollar

Add flow so that buy (onramp) gd transactions show name instead of UniswapV3Pool

Open L03TJ3 opened this issue 1 year ago • 4 comments

Description

After fix here: https://github.com/GoodDollar/GoodDAPP/commit/45895f51b5f25d3d732035ba99f830cb626a1ed5 we will show address or contract names for transactions and no longer show unknown.

For the buy-gd contracts in the current implementation it would show as: UniswapV3Pool as that is the contract doing the swap/sending of gd to account.

  • [x] - add the buy-gd contracts to existing flow for our gd-contracts
  • [x] - Show a name or address for this flow

What should it show? @patpedrosa @sirpy

  1. BuyGD
  2. OnrampGD
  3. ??
  4. Address

L03TJ3 avatar Dec 05 '23 09:12 L03TJ3

BuyGD

patpedrosa avatar Dec 05 '23 12:12 patpedrosa

Will likely not be part of today's release as there is a unresolved discussion how to handle it properly

L03TJ3 avatar Dec 06 '23 10:12 L03TJ3

@sirpy is going to add additional events on contract level to make this easier to catch on wallet side. on hold for now till that is solved

L03TJ3 avatar Dec 08 '23 08:12 L03TJ3

The new buygd contracts are deployed with new events, so the fix required for this can be implemented now

L03TJ3 avatar Dec 11 '23 10:12 L03TJ3