GoodDAPP icon indicating copy to clipboard operation
GoodDAPP copied to clipboard

(Feature) improve feed list performance

Open roma-hladilka opened this issue 2 years ago • 7 comments

Description

replace package add props for better performance

About #3335

Checklist:

  • [x] PR title matches follow: (Feature|Bug|Chore) Task Name
  • [x] My code follows the style guidelines of this project
  • [x] I have followed all the instructions described in the initial task (check Definitions of Done)
  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] I have added reference to a related issue in the repository
  • [x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • [ ] I have added screenshots related to my pull request (for frontend tasks)
  • [ ] I have pasted a gif showing the feature.
  • [ ] @mentions of the person or team responsible for reviewing proposed changes

roma-hladilka avatar Sep 09 '22 08:09 roma-hladilka

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
good-dapp ❌ Failed (Inspect) Sep 20, 2022 at 9:17AM (UTC)
goodid ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 9:17AM (UTC)

vercel[bot] avatar Sep 09 '22 08:09 vercel[bot]

@roma-hladilka put this OPR on hold notifications are top priority

johnsmith-gooddollar avatar Sep 15 '22 16:09 johnsmith-gooddollar

@roma-hladilka which is the status of this PR ? is it really ready to review & merge ? if not how much work left ?

johnsmith-gooddollar avatar Sep 19 '22 12:09 johnsmith-gooddollar

(just answer do not do anything please, do not try even to merge / solve conflicts)

johnsmith-gooddollar avatar Sep 19 '22 12:09 johnsmith-gooddollar

@johnsmith-gooddollar need to re test on all platforms and resolve conflicts, that's all

roma-hladilka avatar Sep 19 '22 13:09 roma-hladilka

@roma-hladilka ok please proceed

johnsmith-gooddollar avatar Sep 19 '22 15:09 johnsmith-gooddollar

@johnsmith-gooddollar tested, could be merged

roma-hladilka avatar Sep 20 '22 09:09 roma-hladilka