GoodDAPP icon indicating copy to clipboard operation
GoodDAPP copied to clipboard

Error: torus signin failed:: Missing privateKey from torus response

Open sentry[bot] opened this issue 3 years ago • 12 comments

How this is possible ?

Sentry Issue: GOODDAPP-3Z5D

Error: torus signin failed:: Missing privateKey from torus response
  at call (components/auth/torus/AuthTorus.js:104:15)
...
(1 additional frame(s) were not displayed)

sentry[bot] avatar May 27 '22 14:05 sentry[bot]

@roma-hladilka still happening

vldkh avatar Jun 23 '22 13:06 vldkh

@vldkh still happening where and how? can you reproduce? please provide example

sirpy avatar Jun 26 '22 06:06 sirpy

@sirpy i see it on Sentry https://sentry.io/organizations/gooddollar/issues/2496422975/?project=1829798&referrer=github_integration image.png

vldkh avatar Jun 30 '22 12:06 vldkh

@roma-hladilka @sirpy Need to be rechecked later. Still happening for some users

vldkhh avatar Jul 18 '22 11:07 vldkhh

@roma-hladilka @serdiukov-o-nordwhale i dont think there is something we can do about it.

sirpy avatar Jul 21 '22 20:07 sirpy

@roma-hladilka @vldkhh should be re-checked one week after release with the new torus version

johnsmith-gooddollar avatar Aug 16 '22 12:08 johnsmith-gooddollar

@roma-hladilka @johnsmith-gooddollar need to be rechecked, still happens to ~200 users everyday

vldkhh avatar Sep 01 '22 16:09 vldkhh

added more logging: https://github.com/GoodDollar/GoodDAPP/commit/7ea5f38696929aadf7067d04bdb8a6183fe88b7b

johnsmith-gooddollar avatar Sep 05 '22 09:09 johnsmith-gooddollar

@serdiukov-o-nordwhale theres not much we can do about it. close this issue. and dont log.error and throw. the last code that handles the error should log it

sirpy avatar Sep 05 '22 10:09 sirpy

@sirpy bit it doesn't logs the torus response and other options. i've added additional log.error just to log which object we actually receive from Torus in such cases

johnsmith-gooddollar avatar Sep 06 '22 11:09 johnsmith-gooddollar

@serdiukov-o-nordwhale just move the log.error to where the rethrown error is caught, or dont catch it in the first place

sirpy avatar Sep 06 '22 12:09 sirpy

@sirpy ok now passing logging options via custom prop: https://github.com/GoodDollar/GoodDAPP/commit/3970f6baa0b960828ff5a1ab94bfbdb3fe53bee6

johnsmith-gooddollar avatar Sep 06 '22 13:09 johnsmith-gooddollar