Na'aman Hirschfeld

Results 175 comments of Na'aman Hirschfeld

@cofin can you review this pls?

Hiya, and thanks for contributing! This is @cofin 's domain. Im fine with whatever he says.

Are you adding a PR? @cofin can you get involved here please?

@cofin @john-ingles @Swannbm - please add your input.

there is still the logging config structure to share, no?

We dont need an asbtract class if a base implementation should already do something. I.e., all configurations have a shared strucure - i assume. Am i missing something?

So, I decided against this approach. I updated the logging config to handle the logic better, and I am updating the app to receive a logging config: https://github.com/starlite-api/starlite/pull/511

That's a very good idea! What utils and dependencies do you have in mind?