Max “Goldstein” Siling
Max “Goldstein” Siling
Okay, I think this is ready. I wasn’t able to run all the tests locally (because some tests failed even on main branch for some reason), but it shouldn’t break...
@bircni Hi! Could you please direct me to my next steps here? This is my first time contributing to egui and I’m a bit confused. I’m happy to add lint...
Sure, I’ve done that.
Thanks for reviewing!
> this is something that can be easily ignored Note that this also creates an inference issue: `t` is inferred as `Never`, so it doesn’t get method autocompletion, proper type...
> Yes, this is indeed unsound and should be made zero-sized. Are zero-sized extern statics portable? I’m unsure because C/++ doesn’t have ZSTs, so I don’t know if LLVM portably...
The one problem I have with my implementation is that this knob is not saved when sharing via link. I could easily fix this, but it will add an extra...
@shepmaster Hi! Looking at the commit history, I think I should ask you to review these changes.
> All that said, I've been mulling over a richer way of saving data about the current playground instance. If enough interest arises from people missing this setting sticking around,...
I signed the commits (adding you as a co-author for the second one).