Goldorion

Results 102 comments of Goldorion

> Make it so that extensions need not to be changed. It will introduce more changed lines than currently as to make it work (currently), I added one line, while...

> > > Make it so that extensions need not to be changed. > > > > > > It will introduce more changed lines than currently as to make...

> You need to re-apply extension on saving, maybe make method to get texture with png extension. But see, once again, you did not test at all but did a...

> But see, once again, you did not test at all but did a minute fix and called it a day.. I found a fix and in no case, I...

> PS: There is one merge conflict I'm not sure what was the conflict, but I merged the master and I had no problem... so I guess it's fixed now.

> Conflict was this change: [7fb7b50](https://github.com/MCreator/MCreator/commit/7fb7b501940d6fe74cf8492973b377e29987f2c9) > > Please make sure this change is present in your PR It seems to be good. I think the conflict was due to...

> I will mark this draft until mappings are done (which means until data lists are merged) I meant I will add mappings when data lists will be merged, but...

> > > I'd implement this like item properties: a list of [accessor-defaultvalue] and a list of [accessorscombination-texture]. But the PR will then need the `StateEditor` to define combinations list,...

> I suggested textures so that we could finally support #129. I will make another PR after this one will be merged. It's another feature, so it has to be...

I added support for Logic and String values. I didn't add extra procedure blocks for them because the current code already supports every variable type.