Fabric-Generator-MCreator icon indicating copy to clipboard operation
Fabric-Generator-MCreator copied to clipboard

Feature mod element doesn't work

Open RealSkullface opened this issue 1 year ago • 7 comments

Issue description

I was made feature elements and it compiled, but the features didn't generate in the game. I tried to add more and less conditions, made them not biome specific, used templates and tried deleting the "build" folder, but nothing worked. Everything's still normal with the only issue that the features don't generate.

How to reproduce this issue?

Step 1: Create a workspace or open one. Step 2: Create a feature modand apply a template. Step 3: Save and run minecraft. Step 4: Create a new world, the features won't be there.

Operating system

Windows

Details

MCreator version: 2023.2 Plugin version: 1.9.5 Generator: Fabric 1.20.1 Other plugins were not included.

Example workspace

bruh_mod.zip

Logs

No response

Issue tracker rule checks (please read carefully)

RealSkullface avatar Jul 04 '23 15:07 RealSkullface

The fix will only be possible when something inside MCreator's code will be fixed (it's due to a behaviour of MCreator). However, you can bypass the problem currently, by adding a procedure returning true for the Additional generation condition procedure selector.

Goldorion avatar Jul 04 '23 17:07 Goldorion

@Goldorion this still isn't working for me. Anyone have any other workarounds? I'm happy to go into the code as well.

Untitled

Oddly enough I can see the generation is slower, as if it's trying to spawn the feature but doesn't. I'm using the 1.19.2 generator.

sdrowan123 avatar Jul 18 '23 01:07 sdrowan123

I was able to fix this by replacing NoOpFeature and NoneFeatureConfiguration in my feature class with a relevant configuration. For me ReplaceBlobsFeature and ReplaceSphereConfiguration.

sdrowan123 avatar Jul 18 '23 21:07 sdrowan123

Is it still happening with the last updates?

Goldorion avatar Mar 15 '24 04:03 Goldorion

This is still happening in 2023.4, at least with custom-built trees. The .nbt models generate just fine with the structures element, but not the feature element.

ravenkhor avatar Apr 25 '24 03:04 ravenkhor

Latest version?

Goldorion avatar Apr 25 '24 13:04 Goldorion

Version 1.10 of the plugin, for 1.20.1, yes.

ravenkhor avatar Apr 26 '24 01:04 ravenkhor