Fabric-Generator-MCreator icon indicating copy to clipboard operation
Fabric-Generator-MCreator copied to clipboard

Brewing stand and potion recipes not working

Open purejosh opened this issue 2 years ago • 4 comments

Issue description

Brewing stands will not accept items that aren't vanilla accepted, and will not create a new potion using a custom recipe.

Also, creating a potion type which includes all 4 items seems to work fine, but assigning it into the brewing stand as a result causes a build error. Unfortunately, it's not showing me the build error, it just says that I need to refactor my workspace, which does not work.

How to reproduce this issue?

Create a potion set. Create a recipe for the brewing stand using any item that's not usually a brewing ingredient, and assign a custom potion as the result item. Observe that there are build errors. Change result item to a vanilla potion. Observe that using the brewing stand will not work with the item that's not usually a brewing ingredient.

Operating system

Windows

Details

MCreator 2022.3.41417 Fabric Generator 1.7-beta-11

Example workspace

No response

Logs

No response

Issue tracker rule checks (please read carefully)

purejosh avatar Oct 20 '22 23:10 purejosh

With Fabric, only potions are accepted as an inpit (bottom) and as the result. The ingredient (top) can only be an item/block item.

Goldorion avatar Oct 21 '22 12:10 Goldorion

By your own definition, this is not working as intended. I'll provide more info, since it appears that I'm not explaining things in an understandable way.

Narrowing it down to one singular issue, I cannot set the result potion to be a potion made in MCreator. It can be set as an existing, vanilla potion. But a custom made potion (complete with potion/splash/lingering/arrow) will cause the following error: image

Here's the potion set I was talking about: image

And here's the recipe for the brewing stand: image

If I set the result item to a potion of leaping, which is vanilla, it works fine. If I set it to a custom potion that was made in MCreator, it fails. I've tested this in Forge, by changing the generator to Forge 1.19.2, and it compiles. This issue is exclusive to the Fabric Generator.

FrogLegs-share.zip

purejosh avatar Oct 21 '22 16:10 purejosh

I found this in the console, I should've provided this sooner.

> Task :compileJava FAILED 
[C:\Users\purejosh\MCreatorWorkspaces\froglegs\fabric\src\main\java\net\purejosh\froglegs\init\FroglegsModBrewingRecipes.java:11](file:///C:/Users/purejosh/MCreatorWorkspaces/froglegs/fabric/src/main/java/net/purejosh/froglegs/init/FroglegsModBrewingRecipes.java:11): error: cannot find symbol 
      PotionBrewing.addMix(Potions.AWKWARD, FroglegsModItems.FROG_LEG, FroglegsModPotions.FROG_LEAPING.get()); 
                                                                                                      ^ 
  symbol:   method get() 
  location: variable FROG_LEAPING of type Potion 
1 error 
FAILURE: Build failed with an exception.
package net.purejosh.froglegs.init;

import net.minecraft.world.item.alchemy.Potions;
import net.minecraft.world.item.alchemy.PotionBrewing;

public class FroglegsModBrewingRecipes {
	public static void load() {
		PotionBrewing.addMix(Potions.AWKWARD, FroglegsModItems.FROG_LEG, FroglegsModPotions.FROG_LEAPING.get());
	}
}

purejosh avatar Oct 21 '22 16:10 purejosh

I found this in the console, I should've provided this sooner

Thanks, I forgot once again to remove a Forge getter that isn't needed with Fabric (.get())

Goldorion avatar Oct 21 '22 18:10 Goldorion

Thank you!

purejosh avatar Nov 05 '22 03:11 purejosh

Sorry for the time it took. I didn't have much free time recently :)

Goldorion avatar Nov 05 '22 12:11 Goldorion

It's okay, it wasn't very critical. I appreciate it anyway!

purejosh avatar Nov 05 '22 12:11 purejosh