Gogh icon indicating copy to clipboard operation
Gogh copied to clipboard

Bad error message and script for gogh.sh

Open alexwolf22 opened this issue 4 years ago • 7 comments

I had a lot of trouble using Gogh for Mac OS using iterm2. I kept getting the error message below. I think it should be more descriptive to help people use Gogh properly.

Unsupported terminal!

Supported terminals:
   mintty and deriviates
   guake
   iTerm2
   elementary terminal (pantheon/elementary)
   mate-terminal
   gnome-terminal
   tilix
   xfce4-terminal

If you believe you have recieved this message in error,
try manually setting `TERMINAL', hint: ps -h -o comm -p $PPID

I tried setting the TERMINAL env value to iTerm2 and other variants and it still would show that message each time I tried rerunning the script.

Similarly I tried running ps -h -o comm -p $PPID and kept getting the output COMM\nlogin which was related at all to the terminal type.

I eventually had to go trough through the script and see that the the $TERM_PROGRAM env is used to set the tone $TERMINAL. The value of this on my machine was 'iTerm.app' and when I set the TERMINAL env to that value it finally worked.

The error message should list add iTerm.app as a supported terminal option instead of the iTerm2 and it should also tell people to trying check the value of $TERM_PROGRAM.

Even better the gogh.sh should be able to detect the terminal type with my machine and setup.

alexwolf22 avatar Nov 15 '19 17:11 alexwolf22