GoesM

Results 27 comments of GoesM

it works! greatly thanks for your help ^_^

@Hynh4u what about the issue you've met ? I just modify the following file https://github.com/carla-simulator/ros-bridge/blob/master/carla_ros_bridge/src/carla_ros_bridge/CARLA_VERSION with following context: ``` 0.9.15 ``` and it works.

However, I noticed that during `deactivate()`, `dyn_handler_.reset()` is executed to try to stop the dynamic parameter callback thread: https://github.com/ros-navigation/navigation2/blob/715df8f3477f6ed1c023d8f928e321bb18c403e5/nav2_amcl/src/amcl_node.cpp#L304-L316 But it seems that it doesn't actually achieve this, so I...

Sure! My future work will follow these steps: - [x] Conduct experiments to ensure `node->remove_on_set_parameters_callback(dyn_handler_);` could shutdown the callback threads properly. - [x] Review all other instances where the dynamic...

some suggestions to avoid such buffer-overflow: - just use the real size of vector as the boundary - design nsg-recovery mechanism for `/map` ?

Interesting suggestion! ^_^ I agree that basic message validation is in need, especially considering the exposure of ros2-topics within the local network, where they are susceptible to both intentional and...

May I open a long-term PR after implementing a basic framework, to continually update it whenever I come across new tickets? Alternatively, should I open a PR dedicated solely to...