Crunchy icon indicating copy to clipboard operation
Crunchy copied to clipboard

changed the merge from using mkvmerge to using ffmpeg

Open elisha464 opened this issue 5 years ago • 3 comments

when merging the subtitles with the video mkvmerge was sometimes throwing warnings, and when it throws a warning the exit code of the program is 1 and that throws an error even though the merge is totally OK I switched the merge to use ffmpeg, it feels much more suited for the job and it also removes the dependency on another executable

Checklist

[X] I've run npm run compile and it produce no error [X] I've run npm run test and it produce no error [X] I've not pushing more than one feature in that pull request [X] My branch is updated with the latest from main when I make that pull request [X] I've tested as much as I can my changes

elisha464 avatar Jan 07 '20 22:01 elisha464

Code Climate has analyzed commit a45f12b2 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Jan 07 '20 22:01 codeclimate[bot]

The merge is not OK. Some episodes have incorrect subtitles, and they need to be corrected. Yes mkvmerge return with an error value for a warning; but the subtitles are really incorrect.

There is an open issue about that: #65, and instead of using a tool which does not warn/errored on invalid subtitles (some of the entries are beyond the length of the video) I would prefer to have a way to detect them and patch the file on the fly.

Godzil avatar Apr 10 '20 13:04 Godzil

are you sure that the problem is because of the subtitles? and if so what kind of fix did you have in mind?

elisha464 avatar Apr 11 '20 15:04 elisha464