godot_openxr icon indicating copy to clipboard operation
godot_openxr copied to clipboard

Add workaround for swapchain release error

Open mgschwan opened this issue 3 years ago • 5 comments

Will release and reinitialize all swapchains when an error during release of a swapchain image occurs

mgschwan avatar Jun 05 '22 17:06 mgschwan

ping @mgschwan , Could you resolve the merge conflict and apply the requested changes? Then we can merge this in.

BastiaanOlij avatar Jul 04 '22 13:07 BastiaanOlij

@m4gr3d would like your opinion on this as well, this is a workaround, not really a fix. We have no idea what is causing the actual issue of the swapchain image not being released properly. It seems to be an issue in the Quest itself.

BastiaanOlij avatar Jul 04 '22 13:07 BastiaanOlij

I've updated my pull request and it says there are no more conflicts.

mgschwan avatar Jul 05 '22 15:07 mgschwan

@mgschwan I still prefer if the relative_transform change is moved into a separate PR. This has nothing to do with fixing the swap chain and I think that one needs further discussion if we want this change.

Also want @m4gr3d feedback on the swapchain fix and see if he is ok with the workaround before we merge.

BastiaanOlij avatar Jul 06 '22 05:07 BastiaanOlij

@mgschwan I've extracted the session and swapchain fixes into separate PRs and I'm merging those. You'll need to redo a PR for the relative transform change.

BastiaanOlij avatar Jul 15 '22 02:07 BastiaanOlij