godot-mod-loader icon indicating copy to clipboard operation
godot-mod-loader copied to clipboard
verified publisher icon GodotModding

Generalize the _load_steam_workshop_zips() method

Open otDan opened this issue 2 years ago • 2 comments

This would be a better option than having a hardcoded way of retrieving those zips, so you can provide a CLI argument that basically says to do a deep search inside the already provided mod path folder

otDan avatar Jun 03 '23 22:06 otDan

With that, we might have the possibility to move ModLoader._load_mod_zips() to _ModLoaderFile.load_mod_zips() as intended in #255. This is currently not possible due to cyclic dependencies.

KANAjetzt avatar Jun 03 '23 22:06 KANAjetzt

The mentioned method: https://github.com/GodotModding/godot-mod-loader/blob/999ec0597c126baf7342293048a9597f48bd3d1b/addons/mod_loader/internal/third_party/steam.gd#L12-L49

  • [ ] Add a "deep search" option to the ModLoader Options.
  • [ ] Add a "depth" option to the ModLoader Options defining how many levels deep the mod loader should search for zip files.
  • [ ] Keep the steam_workshop_enabled option and make it essentially a preset that calls the new method with the right parameters.

KANAjetzt avatar Oct 04 '23 13:10 KANAjetzt