pyrdp icon indicating copy to clipboard operation
pyrdp copied to clipboard

PyRDP hangs when downloading a file of 108 bytes on the client's shared drive

Open Pourliver opened this issue 6 years ago • 3 comments

Weird enough, the player hangs when trying to download a file of 108 bytes. Tested with a Windows 10 client. I can add more detail if needed, but I don't really know what would help with this issue.

Pourliver avatar Jul 29 '19 19:07 Pourliver

The maximum "payload" size that the client can send is 2^14, so 16384. I scripted the creation of these files, and tried to download them all.

The only one that hanged was 108 bytes, and every other N * 2^14 + 108.

Pourliver avatar Jul 31 '19 17:07 Pourliver

This is still reproducible. There's a lot of noise on the device redirection channel, so it's very hard to track what is happening to compare working transfers with non-working transfers. We'll need to add some debug code to help investigate this.

So far I compared two files (one working, one not) and I noticed that the transfer hangs on/after an IORequest from the client to MJ_READ the file descriptor. The working file doesn't have a single READ call, so I'm thinking this might be related, but will need to find time to dig deeper...

alxbl avatar Aug 06 '20 16:08 alxbl

NOTE: While we instrument this, we should address #222 since it's located in the same code area, and maybe shed some light on this.

alxbl avatar Aug 18 '20 15:08 alxbl

2022-11-15_15-06

Managed to fix this at the same time of another issue.

obilodeau avatar Nov 15 '22 20:11 obilodeau

My brother in christ I'm so sad I cant have closure on this bug

Res260 avatar Nov 15 '22 20:11 Res260

Wait i didnt read properly i'm glad to have closure on this bug* 😂

Res260 avatar Nov 15 '22 20:11 Res260