DeploymentContributorFilterer icon indicating copy to clipboard operation
DeploymentContributorFilterer copied to clipboard

Published 20 hours ago • verified publisher icon GoEddie

Fixed various issues with logging, updated README.md

Open purepvd opened this issue 1 year ago • 2 comments

purepvd avatar Sep 20 '23 05:09 purepvd

@purepvd Thanks for your contribution!

This all looks good, however I see that the 'catch' in DeploymentFilter now throws, and I'm not certain of the impact here.

t-johnson avatar Sep 22 '23 13:09 t-johnson

@purepvd Thanks for your contribution!

This all looks good, however I see that the 'catch' in DeploymentFilter now throws, and I'm not certain of the impact here.

Right. It seemed an odd choice to me to swallow errors here. If you're running a publish where you want to exclude parts of your schema (etc), and an error happens, why would you want it to continue updating your database?

There isn't anything in the catch block handling the error. Thoughts?

purepvd avatar Sep 23 '23 02:09 purepvd