DeploymentContributorFilterer icon indicating copy to clipboard operation
DeploymentContributorFilterer copied to clipboard

IsDataLossCheck always returns true

Open martinsmith123456 opened this issue 5 years ago • 0 comments

  • The check for this depends on whether ObjectName is null
  • The assignment to ObjectName uses a conditional expression where, if match.Groups.Count > 0 something is assigned.
  • "the Match.Groups property is a zero-based collection object that always has at least one member." https://docs.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.match.groups?view=netframework-4.8

I presume this was only intended to be true if the match is a success?

martinsmith123456 avatar Jun 06 '19 14:06 martinsmith123456