Yupei Qi

Results 233 comments of Yupei Qi
trafficstars

Allowing `-x c++` is not enough for generic C++ support, we need to add C++ standard library and system headers like what has been done in ClangCompiler.jl: https://github.com/Gnimuc/ClangCompiler.jl/blob/master/src/platform/system.jl

> Struggles still with: > > ``` > /// Severity of a diagnostic. > enum MlirDiagnosticSeverity { > MlirDiagnosticError, > MlirDiagnosticWarning, > MlirDiagnosticNote, > MlirDiagnosticRemark > }; > typedef enum...

`using MlirTypesCallback = void (*)(intptr_t, MlirType *, void *);` this is actually C++, C doesn't have the `using` keyword.

closed by #480, #432, #435

looks like BBB's Artifacts.toml has been updated recently. https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/a4ef056f979007f806ff3980dc6e592f9dd4dd1b/Artifacts.toml#L2762-L2771

replace Artifacts.toml in Clang.jl with the new one in BBB should fix the issue.

I think we need to change https://github.com/JuliaRegistries/General/blob/313a1d3d845ec30060f01ee3209b2955df70889b/C/Clang/Compat.toml#L1-L8 not sure whether there is a caveat of doing this. cc @giordano

Yes. Those entries below may also need to be changed. https://github.com/JuliaRegistries/General/blob/313a1d3d845ec30060f01ee3209b2955df70889b/C/Clang/Compat.toml#L55 I think we can safely cap those versions below Clang-v0.10 to be compatible with Julia up to v1.2.