Glowstone
Glowstone copied to clipboard
Passenger are wrongly sent to other players
The passengers do net appear to be correctly sent in every case.
To reproduce
- Join with multiple accounts
- Let account 1 enter a boat, and leave the boat again
Account 2 will see account 1 still sitting in the boat.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
I did some more testing:
- If player 1 joins first and player 2 second, player 2 is able to see player 1 leave the vehicle. But if player 2 leaves the vehicle, player 1 won't see this.
- If the bugged player + vehicle is destroyed, the player gets reset to the vehicles location, just like you would expect.
- The bugged player can enter other vehicles, but also can't leave them.
- As far as I can see, it doesn't matter who placed the vehicle.
-
SteerVehicleHandler#handleis NOT fired for the bugged player. I don't know much about Netty/Glowstone's network internals, but this doesn't seem right (because only hereGlowEntity#leaveVehicleis used).
Commit: 48cfdfa Branch: dev