Glowstone-Legacy
Glowstone-Legacy copied to clipboard
GlowstoneMC
Continuation of @wow4201's Item Frames
This is a continuation of Item Frames support, started by @wow4201.
I've made some checkstyle fixes, and prevented item from being removed from a player inventory in Creative.
Glowkit: https://github.com/GlowstoneMC/Glowkit/pull/52
@wow4201: If you decide to pick this up again, I'll close this PR and give all the code to you.
Awesome, thanks for continuing this.
Also that's an awful lot of checkstyle fixups.
Cool, great to see my code didn't go to waste. It's 100% function same as Mojang code. However the API part might need some work.
Oh shit @wow4201 is alive and I was criticising his code with no filter just now.
Sorry for that!
@wow4201: Are you interesting in continuing your chest sounds/animation PR, or can I take it over?
I did some work on that one: https://github.com/dequis/Glowstone/compare/pr-211 - Main issue is that it needs some un-copypasting. Also, I don't remember the details (see old PR), but the 'bindchest' concept might be debatable.
@Aaron1011 feel free, I love to contribute my code to this project, I'm just not good at dealing with teams.
@Aaron1011 This PR has been associated with GlowstoneMC/Glowkit#52 - Added extra rotations for 1.8
@turt2live: Are you sure it's getting fired twice? It might be just multiple packets getting sent from holding down right click slightly too long.
The issue does not occur on CraftBukkit, so it must be the code. I am using the same mouse, hand, and client.
@wow4201: Are you still around? I know I took over this PR, but I wanted to talk to you.
@Aaron1011 Your pull request is currently failing to build due to a missing semi-colon.
Please compile locally and test before pushing commits.
@Aaron1011 You have checkstyle problems and you cannot place items in item frames.
Please ensure your code is working before pushing it.
Assigning to @SpaceManiac as "ready to pull" with the assumption that someone will fix the mentioned comment on the ticksLived field. There are also some minor formatting concerns throughout.
@SpaceManiac This pull request is still pending pull. The pull request has been re-tested and is confirmed to be operational.