Glowstone-Legacy
Glowstone-Legacy copied to clipboard
GlowstoneMC
Scoreboards
This PR is the same as #340, except it's against master.
This merges cleanly, if @SpaceManiac wants it merged into master instead of scoreboards
Edited by turt2live
Related Links:
- Glowkit: GlowstoneMC/Glowkit#35
- Ticket: #81
@Aaron1011 Thank you for your contribution! I didn't find a Glowkit dependency in your description. If your pull request does require a Glowkit pull request, please make a new comment with the following text (backticks, , included): GLOWKIT: 1where1` is the Glowkit pull request number.
If your pull request does not require a Glowkit pull request then there is nothing you have to do.
@Jake0oo0: I think it should be left the way it is. Since nametag is one word, it should be left lowercase, as only the first letter of each word is capitalized.
It's fine as-is.
On Sun, Oct 19, 2014 at 1:45 PM, Jake [email protected] wrote:
Minecraft Wiki says it's two words here http://minecraft.gamepedia.com/Name_Tag...I assume that's right...
— Reply to this email directly or view it on GitHub https://github.com/GlowstoneMC/Glowstone/pull/459#issuecomment-59662277.
Sincerely, Travis R
(Turt2Live http://turt2live.com/)
@turt2live This PR has been associated with GlowstoneMC/Glowkit#35 - Scoreboards :D
@Aaron1011 Because this PR causes a huge amount of spam in the console, I do ask that your PR solve it.
It should be very clear from the following resource: click me (image)
@turt2bot: That's actually totally unrelated to my PR. That scoreboards plugin is trying to lookup a player. UuidUtils attempts to fetch it from Mojang, but doesn't handle JSON parsing errors, causing the exception to propagate up.
The Skulls PR (https://github.com/GlowstoneMC/Glowstone/pull/267) properly handles parse and URL related errors; we might want to switch UuidUtils over to it once it gets merged.
@Aaron1011 It's related as the scoreboard API takes in OfflinePlayers. But because Skulls is more mature and on it's way to being pulled and it contains the changes you have described, I am putting this PR on hold until that one is pulled.
PRHOLD: Waiting for #267
Referencing #81 because all the PRs linked from that ticket are closed. Don't mind me.
@Aaron1011 Thanks to some help with @dequis, the following bugs were found:
- When a team has a color, chat does not change
- The formatting is off in
/scoreboard players test(missing spaces) - When using
/scoreboard teams leave TEST, we got this exception (TEST is the team name) - The following caused a client crash:
- Remove existing team TEST
- Add new team
- Join new team
- You have crashed (and will crash until remove from team)
- Lack of error messages in some commands, like
/scoreboard teams this is a bad argument
Additionally, it would be helpful if at least the health objective was implemented.
@Aaron1011 The health objective doesn't work (me and @dequis drowned ourselves)
@Aaron1011
- Players that first join show up on the health scoreboard, but not existing players
- Fixed with a relog
- Suppress the exception message entirely. It should only show if the UUID was unable to be fetched for a player logging in (I'm allowing this to be included in this PR)
Players that first join show up on the health scoreboard, but not existing players Fixed with a relog
This is actually vanilla behavior. I can change it if you want, but it's not a bug.
Suppress the exception message entirely. It should only show if the UUID was unable to be fetched for a player logging in (I'm allowing this to be included in this PR)
Where is an exception being thrown?
This is actually vanilla behavior. I can change it if you want, but it's not a bug.
Well damn. Then what's the vanilla way to add someone to the health scoreboard without relogin?
< dx> Aaron1011: in your scoreboard branch, if there's a health objective and someone isn't showing in the objectives list, taking damage should add them there? < Aaron1011> dx: Yes < Aaron1011> I've confirmed that's vanilla behavior < Aaron1011> Regardless of whether or not yu take damage, you'll get added on relog < Aaron1011> Which is also what vanilla does
(mins later)
< dx> Aaron1011: okay just tested your pr, it does behave as expected. you win. this time. < Aaron1011> Yes!
- Aaron1011 does a victory dance
@Aaron1011 As a warning, your pull request has checkstyle failures. Although these do not affect the pull request process, it is strongly recommended to fix them. The failures are outlined on the Travis-CI build as well as below.
GlowWorld.java:17:8: Unused import - net.glowstone.io.ScoreboardIoService.
GlowWorld.java:18:1: Duplicate import to line 10 - net.glowstone.io.WorldMetadataService.WorldFinalValues.
GlowWorld.java:19:1: Duplicate import to line 11 - net.glowstone.io.WorldStorageProvider.
GlowWorld.java:20:1: Duplicate import to line 12 - net.glowstone.io.anvil.AnvilWorldStorageProvider.