Glowstone-Legacy icon indicating copy to clipboard operation
Glowstone-Legacy copied to clipboard

Tidy up flow-networking usage

Open SpaceManiac opened this issue 9 years ago • 1 comments

Since the MC 1.8 update, Glowstone has been using a custom Netty pipeline different than the one provided by flow-networking. Some methods in GlowProtocol in particular are mandated by flow-networking for use in its pipeline but are not currently used. This should be cleaned up.

SpaceManiac avatar Oct 02 '14 05:10 SpaceManiac

The flow-net components which Glowstone currently uses directly are:

  • Message, an empty interface with some docs, and AsyncableMessage (boolean isAsync()).
  • Codec (T decode(ByteBuf), ByteBuf encode(ByteBuf buf, T message)).
  • MessageHandler (void handle(S session, T message)).
  • ByteBufUtils.
  • ConnectionManager (trivial to refactor out).
  • Session and BasicSession.
  • HandlerLookupService, CodecLookupService, CodecRegistration.
  • AbstractProtocol in some respects (interface differences are hackily worked around).
  • Exception classes (barely actually used).

SpaceManiac avatar Oct 08 '14 03:10 SpaceManiac