Glowkit-Legacy icon indicating copy to clipboard operation
Glowkit-Legacy copied to clipboard

Created FusedExplosive interface.

Open ST-DDT opened this issue 10 years ago • 2 comments

The Issue:

Currently there are no interface similarities between MinecartTNT+Creeper but both entities are Explosives and have a Fuse. It is not possible to specify the explosion range for both of them.

Justification for this PR:

Creeper+MinecartTNT are Explosives, but their interface declaration does not specify that. Both explosives also have a fuse so there is an additional interface for FusedExplosives.

PR Breakdown:

This PR add a FusedExplosive interface and add it to all applicable entities. (Creeper, MinecartTNT) In addition to that it adds the missing ExplosionPrimeEvent to MinecartTNT. (Has not been "Explosive" before) In adddition to that it adds the ExplosiveFuseStartEvent which is called when the FusedExplosives is fused.

Testing Results and Materials:

(Compiled for Bukkit and tested with CraftBukkit) https://dl.dropboxusercontent.com/u/16999313/Bukkit/FusedExplosivesTest-1.0.jar (Plugin) https://dl.dropboxusercontent.com/u/16999313/Bukkit/FusedExplosivesTest.zip (Plugin-Sources)

Old PR(s):

https://github.com/Bukkit/Bukkit/pull/993

ST-DDT avatar Nov 26 '14 22:11 ST-DDT

There was a huge problem with the implementation of explosives that Glowstone will have to decide whether or not it wants to include the same "bugs". This means that this PR is on hold indefinitely and will not get reviewed until explosive entities, and their events, are implemented in Glowstone.

turt2live avatar Nov 26 '14 22:11 turt2live

Ok sounds reasonable. I just wanted to move my PR over.

ST-DDT avatar Nov 26 '14 23:11 ST-DDT