glow icon indicating copy to clipboard operation
glow copied to clipboard

Clearer syntax (potential typo fix) in future/crowdfunding.glow contract. - [opened]

Open kwannoel opened this issue 3 years ago • 3 comments

In GitLab by @flexabyte on Mar 30, 2021, 19:35

Merges master -> master

In an attempt to consolidate some quality examples for potential future contracts I went through the crowdfunding contract and discovered some syntactical inconsistencies, specifically two curly brackets that weren't closed, as well as the fact in the first choice statement you have:

choice {
  | ForAllParticipant (NewPledger) {

with curly bracket and for the last one you have

| ForAllParticipant (Pledger) 
  • without curly bracket

My changes remove the curly brackets, though it could be that those brackets are required. (Not sure how the parser determines this, my intuition tells me we will want them, but I leave that to the MuKn team to establish.

kwannoel avatar Sep 22 '21 06:09 kwannoel

In GitLab by @flexabyte on Mar 30, 2021, 21:32

added 1 commit

  • 28f57f6e - Add multi_share_buy_sig.glow contract and README.md detail explaining required...

Compare with previous version

kwannoel avatar Sep 22 '21 06:09 kwannoel

In GitLab by @flexabyte on Mar 30, 2021, 21:45

added 1 commit

  • c173bece - Add missing #lang glow directive to multi-buy-sig contract.

Compare with previous version

kwannoel avatar Sep 22 '21 06:09 kwannoel

Original PR: https://gitlab.com/mukn/glow/-/merge_requests/125

kwannoel avatar Sep 22 '21 10:09 kwannoel