Passy icon indicating copy to clipboard operation
Passy copied to clipboard

[Bug]: qr scanner error!

Open rubysm opened this issue 1 year ago • 29 comments

Bug description

Scanner error log attached

Expected outcome

No response

Steps to reproduce

No response

Error log

CameraException(error, Attempt to invoke virtual method 'int android.media.EncoderProfiles$VideoProfile.getWidth()' on a null object reference)
#0      AndroidCamera.createCamera (package:camera_android/src/android_camera.dart:112)
<asynchronous suspension>
#1      CameraController.initialize (package:camera/src/camera_controller.dart:296)
<asynchronous suspension>
#2      showConnectDialog.<anonymous closure> (package:passy/screens/common.dart:554)
<asynchronous suspension>

App version

v1.6.0 - Markdown Notes

Submission checklist

  • [X] I have specified the problem in the issue title
  • [X] I have provided a verbose description of the problem

rubysm avatar Sep 12 '23 08:09 rubysm

Hello @rubysm ! Which Android version do you have? Are you sure you granted camera permission to Passy?

GleammerRay avatar Sep 12 '23 10:09 GleammerRay

permission granted android 13 Oneui Do i need to sync everytime by scanning qr? Autosync between pc and android?

rubysm avatar Sep 12 '23 14:09 rubysm

Hmm, that's odd, doesn't happen on my end (pixel Android 13). I think the Android build manifest may need some adjustments. I might be able to provide a safe test build today/tomorrow. Please keep in touch.

I must inform that starting with the next release there will be an easy to set up server feature included for desktop builds which can then be used instead of QR synchronization (~1 month until release).

GleammerRay avatar Sep 12 '23 14:09 GleammerRay

One more feature suggestion: Loading passwords and notes from other password manager like bitwarden will be nice. Which avoid headache in creating logins again

rubysm avatar Sep 13 '23 06:09 rubysm

@rubysm this is already possible, there's a CSV import feature in place. Next update is going to have KDBX import support alongside it as well.

Edit 1: Did you mean directly loading entries? I don't believe I can provide that for the time being.

GleammerRay avatar Sep 13 '23 06:09 GleammerRay

You can access the CSV import screen through the account settings (cogwheel in the top right corner of the screen after you've logged in).

GleammerRay avatar Sep 13 '23 06:09 GleammerRay

App was frozen when I try to import Bitwaadan vault csv file into passy, I mentioned login name, login password, uri, name clearly.

rubysm avatar Sep 13 '23 07:09 rubysm

Im running oneui android 13

rubysm avatar Sep 13 '23 07:09 rubysm

Do u checked importing bitwarden vault?

rubysm avatar Sep 13 '23 07:09 rubysm

Depending on how big your password store is, app may be frozen for up to one minute. Are you sure you waited long enough? I'll make sure to re-test the CSV import feature but I'm pretty sure it works with Bitwarden's CSVs.

GleammerRay avatar Sep 13 '23 07:09 GleammerRay

I waited for a minute and i checked notification for log and ain't no response.

rubysm avatar Sep 13 '23 07:09 rubysm

Only 300 items in my list

rubysm avatar Sep 13 '23 07:09 rubysm

I tested it right now and it works as expected. I apologize but I'm not sure if I can assist you with this in any way other than asking that you try waiting for a longer period of time. Thank you.

Edit 1: I'll consider adding a progress bar for the next update.

GleammerRay avatar Sep 13 '23 07:09 GleammerRay

One more feature request If you going to implement auto sync feature, I would suggest you to implement auto clipboard sync between android and pc (both pswd manager and clipboard manger in same panel).

rubysm avatar Sep 13 '23 07:09 rubysm

My apologies, I am not planning to implement clipboard sync. For that, please use an app like KDE connect. Passy focuses on safe storage of encrypted entries, clipboard sync seems far beyond this scope.

GleammerRay avatar Sep 13 '23 07:09 GleammerRay

I tried an import of 300 csv entries (duplicates) from Bitwarden. It took me a considerable time to import all of them. I will add a progress timer for the next update. Did the app simply freeze on your end or did it show a loading splash screen (with a big Passy logo on it)?

Edit 1: I am planning to provide a test build for you later today with both the potential camera fix and a progress bar indicator for csv imports.

GleammerRay avatar Sep 13 '23 07:09 GleammerRay

Did the app simply freeze on your end or did it show a loading splash screen (with a big Passy logo on it)?

Yeah

am planning to provide a test build for you later today with both the potential camera fix and a progress bar indicator for csv imports.

Sure.

rubysm avatar Sep 13 '23 08:09 rubysm

My apologies, I am not planning to implement clipboard sync. For that, please use an app like KDE connect. Passy focuses on safe storage of encrypted entries, clipboard sync seems far beyond this scope.

It's not only about clipboard sync but you can also keep your clipboard logs in ur protected vault.

rubysm avatar Sep 13 '23 08:09 rubysm

I'll consider clipboard sync for a separate GlitterWare app.

GleammerRay avatar Sep 13 '23 08:09 GleammerRay

I'll consider clipboard sync for a separate GlitterWare app.

Ok, but u should consider storing it in a vault and cross platform sync locally.

rubysm avatar Sep 13 '23 08:09 rubysm

I can not promise it, but I might provide a clipboard sync feature with a store for 30 copies for Passy copy data (no non-Passy copy information) after the next release.

GleammerRay avatar Sep 13 '23 08:09 GleammerRay

I can not promise it, but I might provide a clipboard sync feature with a store for 30 copies for Passy copy data (no non-Passy copy information) after the next release.

Is 30 copies is limit? Why not more than 30?

rubysm avatar Sep 13 '23 10:09 rubysm

@rubysm I'm sorry for failing to provide complete responses earlier today, I was in a big hurry.

I have implemented a CSV import counter and added the android.hardware.camera feature to the android build manifest file, which should hopefully resolve your camera issue. I have compiled a test build from 204c4b77a2a1421e370ea5703fc09d76ada4a25d which you can acquire over at https://www.dropbox.com/scl/fi/aek71iwmu6559kyzn01ks/Passy-v1.6.0-Better-CSV.apk?rlkey=hf34xexz0a0eaxk75qjpdaucd&dl=0. If you wish to test this build, I recommend backing up your Passy account (via Settings -> Backup & Restore) if you have saved any data into it before installing this build. Please report back, and thank you!

Is 30 copies is limit? Why not more than 30?

I can implement it to be 100 copies, but I do not plan to add any extensive settings for the clipboard for the time being. If you wish to discuss the clipboard synchronization feature further I recommend that you open a separate issue. I will notify you if the clipboard synchronization becomes available.

GleammerRay avatar Sep 13 '23 11:09 GleammerRay

CameraException(error, Attempt to invoke virtual method 'int android.media.EncoderProfiles$VideoProfile.getWidth()' on a null object reference)
#0      AndroidCamera.createCamera (package:camera_android/src/android_camera.dart:112)
<asynchronous suspension>
#1      CameraController.initialize (package:camera/src/camera_controller.dart:296)
<asynchronous suspension>
#2      _FutureBuilderState._subscribe.<anonymous closure> (package:flutter/src/widgets/async.dart:624)
<asynchronous suspension>

Camrra crashed.

rubysm avatar Sep 13 '23 13:09 rubysm

I will investigate further into this problem. Did you try importing yet? Please tell me if you can see the counter while the import is in progress.

GleammerRay avatar Sep 13 '23 13:09 GleammerRay

I'm going to update the camera package for the next Passy release. Unfortunately, there isn't anything else I can do about it for now. CSV imports will be optimized too.

GleammerRay avatar Sep 13 '23 13:09 GleammerRay

I will investigate further into this problem. Did you try importing yet? Please tell me if you can see the counter while the import is in progress.

It works but ain't fast and when I try import notes from that same CSV file it created dummy items instead of my vault notes.

rubysm avatar Sep 13 '23 15:09 rubysm

Apologies, I'll revisit CSV import to ensure that it's fast and works correctly for all entry types. I'll also add 2fa csv import support for passwords. While I hope to resolve the camera issue too, I can't promise that, but entry synchronization server is already implemented and tested and will be available soon (it might allow for clipboard synchronization).

I'm sorry that this is your first experience with my app. Truly, I haven't worked on the CSV import feature for quite enough time, most of the import/export functionality is relatively new (dates one release back).

I will notify you once the next release is out. Thank you for your contribution!

GleammerRay avatar Sep 13 '23 15:09 GleammerRay

Hello @rubysm ! New release is available at https://github.com/GlitterWare/Passy/releases/v1.7.0. It resolves the CSV import speed along with the ability to cram more export information into entries.

I am unsure as to whether the camera problem is resolved yet. The camera package has been updated but as all of my devices have been able to use it all along I can not tell if it is fixed for you yet.

Regarding the clipboard synchronization, I have not implemented it yet but it is very likely to be added as an option in settings for the next release. The new synchronization server feature allows for this to happen.

If you're still interested in clipboard synchronization you may want to familiarize yourself with the new dedicated server feature. You can access information on the simple setup process via ⚙️ -> Synchronization servers -> Setup (the setup button is not available on mobile devices).

GleammerRay avatar Nov 29 '23 10:11 GleammerRay