glimesh.tv icon indicating copy to clipboard operation
glimesh.tv copied to clipboard

Guilded URLs often wrong on user profiles

Open danstiner opened this issue 3 years ago • 3 comments

It looks like everyone is ending up with broken guilded.gg URLs on their profiles.

I think this is happening because our user profile pages ask for "Guilded Server URL" which makes people think they should put in the whole URL when we really just want the part after the slash. image

This leads to URLs on profile pages like https://guilded.gg/https://guilded.gg/TheKeep

I get where this is coming from, the guilded docs do call the part after the slash the "URL" but that's simply not what URL means: https://support.guilded.gg/hc/en-us/articles/360040212713-Server-Name-Type-URL

I'm not sure what better language would be to make this clear, maybe we can show a warning if you put in a full URL for any of these fields? My suggestion would be check for :// to detect full URLs

danstiner avatar Mar 07 '21 04:03 danstiner

@mja00 Apologies if you're already in progress on this

I'm providing a social sanitizer in #666 that solves some other issues, but would be a good candidate for handling backend sanitization if required. A frontend validator would still be nice :)

Can chat in #dev about it

Eein avatar Apr 28 '21 07:04 Eein

@Eein Go for it, I had only moved it because I was at one point going to work on it but got distracted, looking at #666, it seems this would be perfect to be fixed in that. :D

mja00 avatar Apr 28 '21 13:04 mja00

@mja00 Due to avoiding frontend validations as its not in the scope of #666 - this ticket should remain open and/or renamed until frontend validators are available for these social usernames.

Edit: #666 now handles these cases.

Eein avatar Apr 29 '21 02:04 Eein