go-external-ip icon indicating copy to clipboard operation
go-external-ip copied to clipboard

Published 20 hours ago • verified publisher icon GlenDC

Input required from the community and users of this library.

Open GlenDC opened this issue 3 years ago • 6 comments

This Library and binary have been written by me, in a long forgotten past. I've noticed however that interest in it never has faded. As a first step I'll go over the project, add CI (testing, quality checks), ensure it works against latest Go versions, and add community guidelines.

I have noticed there are a quite a couple of forks out there. Are any of them active? If so, feel free to be in touch with me to see if we can bring any of your contributions and improvements upstream, so all can benefit from them.

This project had a lot of potential but has never been fully finished. As a community we probably can bring it to a new level. To do this I would like to get some input from the users of this project on what features, improvements and changes you can benefit from. Any suggestions to help shape the roadmap and future direction of this project can help yourself and others.

Kind regards, Glen.

GlenDC avatar Aug 09 '22 16:08 GlenDC

Hi Glen! Only found this library now. Thank you very much for making it. Seems to work fine as it is :-) Only one suggestion: http://diagnostic.opendns.com/myip seems not available anymore

Gys avatar Dec 08 '22 18:12 Gys

When running tests, this didn't seem to support IPV6, only IPV4. It might be a good idea for this library to support both IPV4 and IPV6, IPV4 only, or IPV6 only. This could be selected by the user.

A service supporting both IPV4 and IPV6, relatively simple, is https://ipify.org

tech10 avatar Feb 16 '23 22:02 tech10

I was trying to implement finding external ip for my sockv5er project but then thought of researching a bit to avoid reinventing the wheel. This package checks all the boxes for me. If I have any requirements or something, will surely let you know and possibly raise a PR. Thanks for this package.

platput avatar Mar 09 '23 15:03 platput

Thanks for this library. Since you are seeking input, I have opened a couple of issues (#12 and #13) with ideas/suggestions.

x11x avatar Jul 31 '23 04:07 x11x

Great suggestions @x11x. Sadly I do not have any time or desire to continue maintaining this library though. So if someone wishes to contribute feel free to do so. If all goes well I can give that person (or team of persons) also more rights once a trust relationship is built.

The scope is pretty narrow, so I don't think it would take too much time for that person or team or persons to push this to next level. Other then that it might also be an idea to look for alternatives as perhaps by now there are more options, one being the one you suggest @x11x .

GlenDC avatar Aug 03 '23 14:08 GlenDC

@GlenDC I love this repo and am going to maintain a fork for now (https://github.com/andygeorge/go-external-ip), and have implemented the open PRs from this repo (https://github.com/GlenDC/go-external-ip/pull/11 and https://github.com/GlenDC/go-external-ip/pull/14).

@x11x I'll copy over your filed issues to my repo.

andygeorge avatar Sep 11 '23 14:09 andygeorge