Nuki

[ngeissel]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• [x] If your changes affects code, did your write the tests?
• [x] Are tests passing? (npm test on both front/server)
• [x] Is the linter passing? (npm run eslint on both front/server)
• [x] Did you run prettier? (npm run prettier on both front/server)
• [x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
• [x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• [x] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• [x] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

This service is handling Nuki lock for Gladys Assistant (using MQTT and HTTP for now) : battery, lock state, lock / unlock action.

See https://github.com/ngeissel/Gladys/tree/nuki/server/services/nuki#readme

[codecov[bot]]

Codecov Report

:x: Patch coverage is 99.43343% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 98.67%. Comparing base (acd175e) to head (6884977).

Files with missing lines	Patch %	Lines
server/services/nuki/api/nuki.controller.js	85.71%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2288      +/-   ##
==========================================
+ Coverage   98.66%   98.67%   +0.01%     
==========================================
  Files         914      950      +36     
  Lines       15688    16041     +353     
==========================================
+ Hits        15478    15829     +351     
- Misses        210      212       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[relativeci[bot]]

#3564 Bundle Size — 11.09MiB (+0.71%).

6884977(current) vs acd175e master#3563(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics   6 changes 2 regressions

	Current #3564	Baseline #3563
Initial JS	6.16MiB(+1.1%)	6.09MiB
Initial CSS	309.24KiB(+0.05%)	309.08KiB
Cache Invalidation	70.71%	55.47%
Chunks	51	51
Assets	176(+0.57%)	175
Modules	1631(+0.87%)	1617
Duplicate Modules	21	21
Duplicate Code	0.92%(-1.08%)	0.93%
Packages	136	136
Duplicate Packages	2	2

Bundle size by type   4 changes 4 regressions

	Current #3564	Baseline #3563
JS	8.05MiB (+0.88%)	7.98MiB
IMG	2.59MiB (+0.31%)	2.58MiB
CSS	327.09KiB (+0.05%)	326.93KiB
Fonts	93.55KiB	93.55KiB
Other	18.53KiB (+0.41%)	18.45KiB
HTML	13.58KiB	13.58KiB

Bundle analysis report Branch ngeissel:nuki Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[Pierre-Gilles]

Hi @ngeissel 🙂 Just checking in, I’d love to merge this great PR!

Were you able to take a look at the changes we discussed last time?

[Pierre-Gilles]

@ngeissel Thanks for the feedbacks, be careful you need to run Prettier on the front :)