fix(2191): Migrate from ezsp to ember driver for Z2M
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (
npm teston both front/server) - [x] Is the linter passing? (
npm run eslinton both front/server) - [x] Did you run prettier? (
npm run prettieron both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (
npm run compare-translationson front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
- [x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [x] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
- [x] Did you add fake requests data for the demo mode (
front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Do you think this change could also impact Zigbee2mqtt backups? For instance, if someone is using the old driver and moves to a new Gladys installation with the new driver, would it break the restore process?
From this part, no issue https://github.com/Koenkk/zigbee2mqtt/discussions/21462#discussioncomment-8510320
Coordinator Backup & Restore
- If you have an ezsp v12 backup that you've used for testing before, this should restore it the same. ✅
- If you had been using v13 for previous ezsp tests (no backup available), and you keep your network settings in configuration.yaml the same (meaning they will match that of the adapter the last time it ran), after swapping for ember, it should simply take over where you left off (and this time you should get a backup file out of it as a bonus!).
⚠️ Do we need to check listed dongle between here and in Gladys ?
#2933 Bundle Size — 10.41MiB (0%).
084e89e(current) vs e9b3211 master#2931(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics no changes
| Current #2933 |
Baseline #2931 |
|
|---|---|---|
5.64MiB |
5.64MiB |
|
304.89KiB |
304.89KiB |
|
0% |
0% |
|
51 |
51 |
|
173 |
173 |
|
1511 |
1511 |
|
21 |
21 |
|
0.83% |
0.83% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type no changes
| Current #2933 |
Baseline #2931 |
|
|---|---|---|
7.43MiB |
7.43MiB |
|
2.54MiB |
2.54MiB |
|
321.79KiB |
321.79KiB |
|
93.55KiB |
93.55KiB |
|
17.79KiB |
17.79KiB |
|
13.58KiB |
13.58KiB |
Bundle analysis report Branch cicoub13:fix-2191 Project dashboard
Generated by RelativeCI Documentation Report issue
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 98.53%. Comparing base (e9b3211) to head (084e89e).
:warning: Report is 135 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2196 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 876 876
Lines 14420 14420
=======================================
Hits 14209 14209
Misses 211 211
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@cicoub13 Thanks for the PR! Were you able to test the PR? :)
@cicoub13 Thanks for the PR! Were you able to test the PR? :)
Not yet 😐
@cicoub13 If you need extra hardware to be able to test this without touching your main instance, don't hesitate 😄 (extra dongle, extra Linux server, anything)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@Pierre-Gilles @cicoub13 . I'm running this update with the Sonoff E USB, and I find it very stable and fast with this new version of Zigbee2MQTT. I upgraded simultaneously to Zigbee2MQTT version 2.1.3. A great upgrade. I would recommend everyone to use the E version after this update.
Hello @cicoub13, any news on this? :)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.