WIP : Adding ikea e1524/e1810
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [x] Are tests passing? (
npm teston both front/server) - [x] Is the linter passing? (
npm run eslinton both front/server) - [ ] Did you run prettier? (
npm run prettieron both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (
npm run compare-translationson front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
- [ ] Did you add fake requests data for the demo mode (
front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!
#2875 Bundle Size — 10.29MiB (+0.02%).
dbfe104(current) vs 8b1c577 master#2873(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
2 changes
1 regression
| Current #2875 |
Baseline #2873 |
|
|---|---|---|
5.59MiB(+0.03%) |
5.59MiB |
|
304.73KiB |
304.73KiB |
|
54.21% |
0% |
|
51 |
51 |
|
171 |
171 |
|
1497 |
1497 |
|
21 |
21 |
|
0.84% |
0.84% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type
1 change
1 regression
| Current #2875 |
Baseline #2873 |
|
|---|---|---|
7.38MiB (+0.02%) |
7.38MiB |
|
2.48MiB |
2.48MiB |
|
321.52KiB |
321.52KiB |
|
93.55KiB |
93.55KiB |
|
17.62KiB |
17.62KiB |
|
13.58KiB |
13.58KiB |
Bundle analysis report Branch paddyponchero:adding-IKEA-E1524/... Project dashboard
Generated by RelativeCI Documentation Report issue
hey @paddyponchero, any news on this PR ? :)
I don't have much time as I am renovating a house in evenings and weekends on top of a full time job.
I was having trouble pushing the changes to github after test, prettier etc.
On Mon, 30 Sept 2024, 04:12 Pierre-Gilles Leymarie, < @.***> wrote:
hey @paddyponchero https://github.com/paddyponchero, any news on this PR ? :)
— Reply to this email directly, view it on GitHub https://github.com/GladysAssistant/Gladys/pull/2120#issuecomment-2381917651, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACELGZA2PT2JPKRXIIHATF3ZZC6SBAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRHEYTONRVGE . You are receiving this because you were mentioned.Message ID: @.***>
Ok, let me know if you need help finishing this! Good luck on your house :)
Hey @paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.52%. Comparing base (
8b1c577) to head (dbfe104). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2120 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 868 868
Lines 14287 14295 +8
=======================================
+ Hits 14076 14084 +8
Misses 211 211
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @paddyponchero, the PR is just missing a
npm run prettierin theserverfolder, I would love to merge this in Gladys :)
Seems to have pushed correctly this time. Thanks.
Seems to have pushed properly now,
On Fri, 8 Nov 2024, 16:20 Pierre-Gilles Leymarie, @.***> wrote:
Hey @paddyponchero https://github.com/paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)
— Reply to this email directly, view it on GitHub https://github.com/GladysAssistant/Gladys/pull/2120#issuecomment-2465194744, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACELGZGVVCILIJR7DN6INDDZ7TQEDAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGE4TINZUGQ . You are receiving this because you were mentioned.Message ID: @.***>