Gladys icon indicating copy to clipboard operation
Gladys copied to clipboard

WIP : Adding ikea e1524/e1810

Open paddyponchero opened this issue 1 year ago • 4 comments

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • [x] Are tests passing? (npm test on both front/server)
  • [x] Is the linter passing? (npm run eslint on both front/server)
  • [ ] Did you run prettier? (npm run prettier on both front/server)
  • [x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

paddyponchero avatar Sep 17 '24 10:09 paddyponchero

#2875 Bundle Size — 10.29MiB (+0.02%).

dbfe104(current) vs 8b1c577 master#2873(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2875
     Baseline
#2873
Regression  Initial JS 5.59MiB(+0.03%) 5.59MiB
No change  Initial CSS 304.73KiB 304.73KiB
Change  Cache Invalidation 54.21% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1497 1497
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.84% 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2875
     Baseline
#2873
Regression  JS 7.38MiB (+0.02%) 7.38MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 321.52KiB 321.52KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch paddyponchero:adding-IKEA-E1524/...Project dashboard


Generated by RelativeCIDocumentationReport issue

relativeci[bot] avatar Sep 17 '24 10:09 relativeci[bot]

hey @paddyponchero, any news on this PR ? :)

Pierre-Gilles avatar Sep 30 '24 03:09 Pierre-Gilles

I don't have much time as I am renovating a house in evenings and weekends on top of a full time job.

I was having trouble pushing the changes to github after test, prettier etc.

On Mon, 30 Sept 2024, 04:12 Pierre-Gilles Leymarie, < @.***> wrote:

hey @paddyponchero https://github.com/paddyponchero, any news on this PR ? :)

— Reply to this email directly, view it on GitHub https://github.com/GladysAssistant/Gladys/pull/2120#issuecomment-2381917651, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACELGZA2PT2JPKRXIIHATF3ZZC6SBAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRHEYTONRVGE . You are receiving this because you were mentioned.Message ID: @.***>

paddyponchero avatar Oct 01 '24 14:10 paddyponchero

Ok, let me know if you need help finishing this! Good luck on your house :)

Pierre-Gilles avatar Oct 04 '24 01:10 Pierre-Gilles

Hey @paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)

Pierre-Gilles avatar Nov 08 '24 16:11 Pierre-Gilles

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.52%. Comparing base (8b1c577) to head (dbfe104). Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2120   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files         868      868           
  Lines       14287    14295    +8     
=======================================
+ Hits        14076    14084    +8     
  Misses        211      211           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 09 '24 02:11 codecov[bot]

Hey @paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)

Seems to have pushed correctly this time. Thanks.

paddyponchero avatar Nov 09 '24 02:11 paddyponchero

Seems to have pushed properly now,

On Fri, 8 Nov 2024, 16:20 Pierre-Gilles Leymarie, @.***> wrote:

Hey @paddyponchero https://github.com/paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)

— Reply to this email directly, view it on GitHub https://github.com/GladysAssistant/Gladys/pull/2120#issuecomment-2465194744, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACELGZGVVCILIJR7DN6INDDZ7TQEDAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGE4TINZUGQ . You are receiving this because you were mentioned.Message ID: @.***>

paddyponchero avatar Nov 09 '24 02:11 paddyponchero