Gladys
Gladys copied to clipboard
[Zwave] Multilevel switch support (Dimmer and Curtains)
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (
npm test
on both front/server) - [x] Is the linter passing? (
npm run eslint
on both front/server) - [x] Did you run prettier? (
npm run prettier
on both front/server) ~- [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)~ - [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging. ~- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)~
- [x] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
- [ ] Did you add fake requests data for the demo mode (
front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
This PR is to manage multilevel switch. These devices could have multiple purpose. It handles specific curtains and standard dimmers.
Dashboard
Intégration
Tested on real life devices with Fibaro Walli Roller Shutter & Fibaro Walli Dimmer
This update introduces a new way to add multiple features from the same zWave property. This is usefull for example to manage, with the same property (currentValue) two different features: a Dimmer and a Binary state. For Dimmers, turning the device ON executes a restorePrevious state (cloning real button behavior).
#2546 Bundle Size — 10.13MiB (+0.05%).
3a75f91(current) vs 88e10e2 master#2542(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
2 changes
1 regression
Current #2546 |
Baseline #2542 |
|
---|---|---|
5.45MiB (+0.09% ) |
5.44MiB |
|
302.96KiB |
302.96KiB |
|
53.65% |
53.58% |
|
51 |
51 |
|
170 |
170 |
|
1479 |
1479 |
|
21 |
21 |
|
0.82% |
0.82% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type
1 change
1 regression
Current #2546 |
Baseline #2542 |
|
---|---|---|
7.23MiB (+0.07% ) |
7.22MiB |
|
2.46MiB |
2.46MiB |
|
319.75KiB |
319.75KiB |
|
93.55KiB |
93.55KiB |
|
17.53KiB |
17.53KiB |
|
13.58KiB |
13.58KiB |
Bundle analysis report Branch sescandell:zwaveMultilevelSwitch Project dashboard
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.40%. Comparing base (
a6569de
) to head (3a75f91
). Report is 8 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2061 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 847 858 +11
Lines 13820 14038 +218
==========================================
+ Hits 13598 13814 +216
- Misses 222 224 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for checking the forum, I've added some comments about this PR.
https://community.gladysassistant.com/t/evolution-du-service-z-wave-js-ui/8692/38