Gladys
Gladys copied to clipboard
[Zwavejs] Support Air Temperature & Power properties from Multilevel Sensor Command Class
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (
npm test
on both front/server) - [x] Is the linter passing? (
npm run eslint
on both front/server) - [x] Did you run prettier? (
npm run prettier
on both front/server) - [ ] If you are adding a new features/services, did you run integration comparator? (
npm run compare-translations
on front) - [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
- [ ] Did you add fake requests data for the demo mode (
front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add support of the Air Temperature & Power properties from the Multilevel Sensor Command class:
Tested on real device:
- Air temperature: with the Fibaro Door/Window Sensor 2 (not at all the best device for this data... a dedicated one would be prefered)
- Power: Fibaro wall plug
MQTT message samples (grabbed and tested from zWaveJS UI):
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.32%. Comparing base (
185fe8a
) to head (e3bd5cf
).
Additional details and impacted files
@@ Coverage Diff @@
## master #2027 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 836 836
Lines 13269 13286 +17
=======================================
+ Hits 13047 13064 +17
Misses 222 222
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Job #2395: Bundle Size — 9.83MiB (0%).
e3bd5cf(current) vs 185fe8a master#2390(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics no changes
Current Job #2395 |
Baseline Job #2390 |
|
---|---|---|
5.34MiB |
5.34MiB |
|
303.16KiB |
303.16KiB |
|
0% |
0% |
|
51 |
51 |
|
165 |
165 |
|
1454 |
1454 |
|
20 |
20 |
|
0.8% |
0.8% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type no changes
Current Job #2395 |
Baseline Job #2390 |
|
---|---|---|
7.03MiB |
7.03MiB |
|
2.37MiB |
2.37MiB |
|
319.67KiB |
319.67KiB |
|
93.55KiB |
93.55KiB |
|
16.93KiB |
16.93KiB |
|
13.58KiB |
13.58KiB |
View job #2395 report View sescandell:zwavejs-temperature branch activity View project dashboard
PR for documentation is available here: https://github.com/GladysAssistant/v4-website/pull/255