Ecovacs

[ngeissel]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• [x] If your changes affects code, did your write the tests?
• [x] Are tests passing? (npm test on both front/server)
• [x] Is the linter passing? (npm run eslint on both front/server)
• [x] Did you run prettier? (npm run prettier on both front/server)
• [x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• [x] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add Ecovacs service that allows to add vacbots in Gladys. It handles basic commands as : clean, pause, stop, return to charge station. It returns : batery level and clean reports. It also add to gladys a brand new vacbot box (regrouping all main function in only one box). More information here :https://github.com/ngeissel/Gladys/tree/ecovacs/server/services/ecovacs.

[VonOx]

@ngeissel if you need functional test, I've ecovacs deebot.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 99.28315% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.42%. Comparing base (09a7987) to head (f55117f).

:exclamation: Current head f55117f differs from pull request most recent head 44dede8

Please upload reports for the commit 44dede8 to get more accurate results.

Files	Patch %	Lines
...ver/services/ecovacs/lib/device/vacbot.setValue.js	90.00%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
+ Coverage   98.40%   98.42%   +0.01%     
==========================================
  Files         858      879      +21     
  Lines       14081    14317     +236     
==========================================
+ Hits        13857    14091     +234     
- Misses        224      226       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ngeissel]

@ngeissel if you need functional test, I've ecovacs deebot.

@VonOx great ans thanks ! work still in progress, this branch shoud control a deebot with start stop pause. I tested it with an deebot 920. I have another branch to handle a dashbord box and listen to events from the bots still in WIP. I just corrected some typos, but I am in holidays this week so I have no access to my vacuum bot. Usually I build an image here if you have time to test and give feedback : https://hub.docker.com/layers/ngeissel/gladys/ecovacsdev/images/sha256-faa31cc0ff8e3810d38b65d84ce54f523bed54a31adfa8593da5029683049f0d?context=repo

[VonOx]

I will, holidays too 🎿

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[relativeci[bot]]

#2577 Bundle Size — 10.25MiB (+1.1%).

44dede8(current) vs 09a7987 master#2576(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics   6 changes 2 regressions

	Current #2577	Baseline #2576
Initial JS	5.51MiB(+1.05%)	5.46MiB
Initial CSS	303.12KiB(+0.05%)	302.96KiB
Cache Invalidation	69.9%	63.14%
Chunks	51	51
Assets	171(+0.59%)	170
Modules	1498(+1.22%)	1480
Duplicate Modules	21	21
Duplicate Code	0.81%(-1.22%)	0.82%
Packages	124	124
Duplicate Packages	3	3

Bundle size by type   4 changes 4 regressions

	Current #2577	Baseline #2576
JS	7.31MiB (+1.07%)	7.24MiB
IMG	2.5MiB (+1.37%)	2.46MiB
CSS	319.91KiB (+0.05%)	319.75KiB
Fonts	93.55KiB	93.55KiB
Other	17.61KiB (+0.47%)	17.53KiB
HTML	13.58KiB	13.58KiB

---

Bundle analysis report Branch ngeissel:ecovacs Project dashboard

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.