Z2M Add support for smart valve

[VonOx]

Related to => https://community.gladysassistant.com/t/vanne-zigbee2mqtt-absence-dun-parametre/7451

[codecov[bot]]

Codecov Report

Base: 97.27% // Head: 97.27% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (1e3581c) compared to base (1e02ce6). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1581   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         643      643           
  Lines        9689     9694    +5     
=======================================
+ Hits         9425     9430    +5     
  Misses        264      264           

Impacted Files	Coverage Δ
server/services/zigbee2mqtt/exposes/numericType.js	100.00% <ø> (ø)
server/services/zigbee2mqtt/exposes/enumType.js	100.00% <100.00%> (ø)
server/utils/constants.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[atrovato]

That's a good question, I have same the problem according to your comment on the cover feature. I keep thinking about it... I will let you know once I find the solution.

[atrovato]

@VonOx do you know how to handle this 3 states feature? In dashboard view?

Timer_state (enum)

Value can be found in the published state on the timer_state property. It's not possible to read (/get) this value. To write (/set) a value publish a message to topic zigbee2mqtt/FRIENDLY_NAME/set with payload {"timer_state": NEW_VALUE}. The possible values are: disabled, active, enabled.

You can add the mapping on disabled, active, enabled values in enumType.js file.

[VonOx]

OK got it , I was afraid of some side effect.

In front I think I will mimic your cover component.

[VonOx]

@atrovato @Pierre-Gilles

What do you think about that ?

Color change if timer is active

[Pierre-Gilles]

@VonOx Nice! Have you tried putting the indicator on the left ?

[VonOx]

@VonOx Nice! Have you tried putting the indicator on the left ?

Left of the button group

[Pierre-Gilles]

Looks cleaner to me! what do you think of this change?

[VonOx]

Based on your comment on #1576 => https://github.com/GladysAssistant/Gladys/pull/1576#issuecomment-1204999633

For button feedback while updating value, what about a spinner that replace the text ? ( I'm waiting for @atrovato feedback too )

[Pierre-Gilles]

Spinner inside the button could work!

[atrovato]

I'm not sure this matches the feature actions.

The definition in z2m says you can set 1 of this 3 values: disabled, active, enabled.

Where is the active value to set? Is the green icon an action button or only an indicator? Did I miss something?

EDIT: but I prefer the 2nd try, on the left, and I like it ;)

[Pierre-Gilles]

@VonOx Is this ready for review? Tested in real life?

[VonOx]

Only in demo mode.

[Pierre-Gilles]

Ok, can you post a message here to get some testers? https://community.gladysassistant.com/t/vanne-zigbee2mqtt-absence-dun-parametre/7451/11

[VonOx]

@Pierre-Gilles there is only one user with this device, z2m stuff is not user friendly for testing. I will ask anyway.

[Pierre-Gilles]

@VonOx Let me know when you have news on this ^^

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.