signal2html icon indicating copy to clipboard operation
signal2html copied to clipboard

Remove empty messages

Open GjjvdBurg opened this issue 2 years ago • 2 comments

This builds on PR #35. After the database migration to 110 I have some empty messages in my threads, so this attempts to filter these out. This in turn can lead to repeated date messages with nothing in between, so those are filtered out too now.

To be merged after #35 is merged.

GjjvdBurg avatar Jul 23 '21 16:07 GjjvdBurg

Good point @ericthegrey! Although this might be considered "fair use", it would probably be good to consider moving all the Signal derived code to a separate file, include their GPLv3 license on that file, and consider licensing our work as GPLv3 too. As far as I can tell this would mainly be the types.py code. I'm not opposed to changing our license, but let me know what you think.

GjjvdBurg avatar Aug 08 '21 12:08 GjjvdBurg

I have no objection to doing any of that. I also do not know the implications of distributing code that mixes licenses (I guess none, but it could impact someone who is distributing a compiled version of it). Perhaps the signal folks have some opinion on the matter too.

ericthegrey avatar Aug 08 '21 12:08 ericthegrey