paper2remarkable icon indicating copy to clipboard operation
paper2remarkable copied to clipboard

Added lxml_html_clean and updated pdfplumber dependencies

Open koddas opened this issue 1 year ago • 3 comments

The LXML project has separated its HTML cleaner into its own project, breaking the current build. This change updates the required packages list in setup.py to reflect that change. Also, for some reason, the build didn't finish as expected unless I updated the pdfplumber dependency to 0.11.

koddas avatar Jun 11 '24 13:06 koddas

Thanks for this @koddas! Looks like some tests are failing for unrelated reasons, I'll take a look at those soon

GjjvdBurg avatar Jun 13 '24 21:06 GjjvdBurg

@GjjvdBurg No worries. Is there a way to run the tests locally? The readme isn't that informative on the matter :)

koddas avatar Jun 16 '24 23:06 koddas

Well, this sucks... I managed to to commit some changes I made to the wrong branch. It's totally fine if you reject the lastest commit, it was supposed to be a new PR after the current PR has been approved.

koddas avatar Jun 19 '24 21:06 koddas

Thanks for the changes @koddas! I'm happy to merge this with the addition of the DiVa provider, but the tests are currently failing because of formatting issues, and the test_diva_2 test fails as well (see comment). Formatting configuration can be found in the .pre-commit.yaml file. Don't worry about the other tests, I can fix those later after merging this in. Thanks for your help!

GjjvdBurg avatar Jul 22 '24 22:07 GjjvdBurg

Thanks @koddas, merged!

GjjvdBurg avatar Aug 08 '24 21:08 GjjvdBurg