elm-hedley icon indicating copy to clipboard operation
elm-hedley copied to clipboard

Port to v0.18

Open amitaibu opened this issue 8 years ago • 15 comments

amitaibu avatar May 11 '16 02:05 amitaibu

Waiting for https://github.com/rgrempel/elm-route-hash/issues/13#issuecomment-224367690

amitaibu avatar Jun 07 '16 18:06 amitaibu

I would love to see this ported to v0.17. Looks like a great learning resource!

michallepicki avatar Sep 18 '16 14:09 michallepicki

Indeed, just missing some time. Hopefully will get it going soon with other Gizra devs.

amitaibu avatar Sep 19 '16 17:09 amitaibu

I'm working on this. elm-route-url already supports 0.17 and there are no more blocking dependencies.

@amitaibu, if you give me access to the repo I will push a new branch with my current changes so anyone else can contribute.

DavidHernandez avatar Sep 28 '16 15:09 DavidHernandez

There are some packages that were not being handled using the elm package manager, instead they are directly on a vendor folder. One of them at least, is not going to be upgraded to 0.17: https://github.com/rgrempel/elm-web-api/issues/17

I'm investigating if this vendor is really necessary or if we can get rid of it.

DavidHernandez avatar Sep 29 '16 10:09 DavidHernandez

Only Location seems to be used, so that should be easy. I found two modules that are using it: Config/Update.elm and Pages/GithubAuth/Update.elm

michallepicki avatar Sep 29 '16 20:09 michallepicki

@DavidHernandez did you have any progress? I would love to see a port to 0.17!

lisardo avatar Nov 04 '16 19:11 lisardo

Not really, and I actually lost some of the progress as my laptop was stolen :(

I will try to allocate some time during the next few weeks to work on this.

DavidHernandez avatar Nov 05 '16 00:11 DavidHernandez

I'm starting to work on this again. Following the original proposal from @amitaibu, I've removed everything I will start from the begining. All the work will be done on the same PR, on this branch from my fork: https://github.com/DavidHernandez/elm-hedley/tree/0.17-upgrade

I will go replicating each of the existing pages. I already started with the login. If anyone wants to help, just fork my repo and do PRs.

DavidHernandez avatar Nov 09 '16 17:11 DavidHernandez

👍

amitaibu avatar Nov 09 '16 18:11 amitaibu

As 0.18 has been released, so we will go directly for the 0.18 upgrade.

DavidHernandez avatar Nov 15 '16 16:11 DavidHernandez

@DavidHernandez What's the status on this ? Do you need any help ?

nedSaf avatar Nov 24 '16 07:11 nedSaf

@nader77 right now there is only one vendor library left with no support for elm 0.18 and it is https://github.com/rgrempel/elm-route-url

I will open an issue on that repository about upgrading to 0.18.

DavidHernandez avatar Nov 27 '16 08:11 DavidHernandez

There's already a PR for that -- https://github.com/rgrempel/elm-route-url/pull/19

amitaibu avatar Nov 27 '16 08:11 amitaibu

By the way, to work with different versions of Elm, there is this npm module that does a nice job: https://www.npmjs.com/package/elm-version-manager

DavidHernandez avatar Nov 27 '16 08:11 DavidHernandez