GiviMAD

Results 84 comments of GiviMAD

> > Also IDK if placing the code in the voice bundle is correct > > As the websocket adapter is for audio streams in general, I would say that...

I have to refactor the code into the websocket.io bundle for it to build without modifying the BOM features, but I think it also makes sense to have it there...

I think these is ready for the review. I was able to write a POC in the UI and everything seems to work. A quick video recorded with my mobile:...

> out of curiosity: why do we have kotlin in our pom.xml? AFAIK Kotlin as a language itself not allowed to be used in OH. Are there libraries that we...

Hey @digitaldan , @lsiepel. I've been looking at this today and I was able to make it work with the included docker-compose setup, and for me it seems to be...

@dalgwen if you have any chance to review these PR I'll appreciate any feedback you can give me. You can ignore changes outside the pulseaudio binding as those are pending...

> Sorry for the delay ! > > > I have removed some options, like the preferred port > > I'm personnaly OK with that, because I don't use it,...

> I have another comment : on PipedAudioStream, you have a "closed" AtomicBoolean. Is AtomicBoolean really mandatory ? Manipulating this class involves locking on every read / change. A lock...

Hey @dalgwen sorry for the delay. > ... > > I think we could add something like that : At start, browsing the matching simple-tcp-module-client and add them to the...

@dalgwen, I think that the latest comments are addressed on the last version. Instead of reusing the pre-existent modules for the device, I opted by removing them to avoid adding...