impact-graph icon indicating copy to clipboard operation
impact-graph copied to clipboard

Add giveth tag to subgraph queries

Open aminlatifi opened this issue 1 year ago • 4 comments

In order to get a higher rate limit from subgraph, we can set giveth as source value in our requests

image

aminlatifi avatar Mar 29 '23 13:03 aminlatifi

I added this issue to performance epic, is it still valid?

MoeNick avatar Feb 06 '24 13:02 MoeNick

A FE stuff. Not applied yet, am I right @MohammadPCh ?

aminlatifi avatar Feb 07 '24 09:02 aminlatifi

Is this still needed @MoeNick @MohammadPCh @aminlatifi

jainkrati avatar Apr 10 '24 13:04 jainkrati

The issue has not appeared for a while, but it's better to implement this feature for future proof.

aminlatifi avatar Apr 10 '24 13:04 aminlatifi

@maryjaf to test and verify The Subgraph endpoint has changed so please test related features (like GIV balance, staked balance, locked token balance, APR, and GIVpower balance)

RamRamez avatar May 19 '24 10:05 RamRamez

@aminlatifi should I add this tag to MPETH_GRAPHQL_PRICES_URL and POIGN_ART_SUBGRAPH_URL as well? (in impact-graph env vars)

RamRamez avatar May 19 '24 10:05 RamRamez

@aminlatifi should I add this tag to MPETH_GRAPHQL_PRICES_URL and POIGN_ART_SUBGRAPH_URL as well? (in impact-graph env vars)

I don't know how often they are called and whether we suffer from rate limiting there.

aminlatifi avatar May 20 '24 05:05 aminlatifi

@maryjaf to test and verify The Subgraph endpoint has changed so please test related features (like GIV balance, staked balance, locked token balance, APR, and GIVpower balance

I've tested stake,unstake,lock,harvest flows and there is no problem but the APR is shown 0, I haven't more data about calculating APR it seems there is a problem relate to this @RamRamez image

maryjaf avatar May 20 '24 09:05 maryjaf

@maryjaf to test and verify The Subgraph endpoint has changed so please test related features (like GIV balance, staked balance, locked token balance, APR, and GIVpower balance

I've tested stake,unstake,lock,harvest flows and there is no problem but the APR is shown 0, I haven't more data about calculating APR it seems there is a problem relate to this @RamRamez image

I think the APR problem is related to Subgraph on staging, because I used staging branch locally with production Subgraph endpoints and it was working fine.

RamRamez avatar May 20 '24 16:05 RamRamez