impact-graph
impact-graph copied to clipboard
Giveth
Add & automate update reminders to notification center & emails for verified project owners
Some project owners either don't check their email accounts or have unsubscribed from Giveth emails. The verification team thinks that it is important to remind verified project owners that they need to add an update so that they dont lose their verified status.
Two notifications to be added to the notification center - these would be sent to verified projects
45 days without an update - friendly reminder: "Don't forget to add regular updates to your project to keep your verified status! - Learn more"
90 days without an update - "You have 14 days to add an update to avoid badge expiration - Learn more"
Something like that.
if @CarlosQ96 is busy this week you may like to take it @mohammadranjbarz , can you take a look?
Hey hi guys, I would love to check in here to see if there is any chance to estimate when this can be implemented, please. @MoeNick @CarlosQ96 or @mohammadranjbarz
Hey hi guys, I would love to check in here to see if there is any chance to estimate when this can be implemented, please. @MoeNick @CarlosQ96 or @mohammadranjbarz
Hey @NikolaCreatrix @MoeNick I haven't looked over this issue, but as we need to modify something in notification-center and impact-graph I think it would last about 2-3 days( assuming copies are ready and there is no blocker) @CarlosQ96 WDYT?
@MoeNick here is the template Can you add in the link for the template for this https://www.figma.com/file/hNqwpebu4JCy1XIed2c862/Giveth-Public?type=design&node-id=23-48916&mode=design&t=7GnTh1lZ7WYORXWj-4
I talked with @mohammadranjbarz and he will take care of web and email notification of this issue. FOR THIS WEEK
Some project owners either don't check their email accounts or have unsubscribed from Giveth emails. The verification team thinks that it is important to remind verified project owners that they need to add an update so that they dont lose their verified status.
Two notifications to be added to the notification center - these would be sent to verified projects
45 days without an update - friendly reminder: "Don't forget to add regular updates to your project to keep your verified status! - Learn more"
90 days without an update - "You have 14 days to add an update to avoid badge expiration - Learn more"
Something like that.
@WhyldWanderer What is the link for Learn More, after clicking on that, we should redirect to what URL?
@MoeNick @WhyldWanderer I guess also we need to pu project name in notification text that when use clicks on that redirect them to project's page like other notifications, so I think we should modify the notification texts
I guess also we need to pu project name in notification text that when use clicks on that redirect them to project's page like other notifications, so I think we should modify the notification texts
Maybe something like this:
-
45 days without an update - friendly reminder: "[projectname] has not been updated in a while. Remember to add regular updates to your project to keep your verified status!"
In this notification, they can click the project name and it should take them to "giveth.io/project/[projectslug]?tab=updates" for whichever project of theirs needs the update?
-
90 days without an update - "You have 14 days to add an update to [projectname] to avoid badge expiration - Learn more"
In this notification, "Learn more" should link to "youtu.be/sRhp74CcGU8?si=UWLAMVjIAiT_rO5y"
wdyt?
@WhyldWanderer @MoeNick
I saw we already use notification center for sending reminder emails, if we want to exactly send notifications when we are sending email so might not be needed to change impact-graph, we just need to modify some notificationTypes with copies that you provided to make it work
https://github.com/Giveth/impact-graph/blob/staging/src/services/cronJobs/checkProjectVerificationStatus.ts#L107-L150
WDYT?
Unfortunately no emails get sent due to Segment issues or something.. At this point we have no process for notifying the user that they need to add an update.
Does that change what you are suggesting?
@WhyldWanderer @MoeNick
I saw we already use notification center for sending reminder emails, if we want to exactly send notifications when we are sending email so might not be needed to change impact-graph, we just need to modify some notificationTypes with copies that you provided to make it work
https://github.com/Giveth/impact-graph/blob/staging/src/services/cronJobs/checkProjectVerificationStatus.ts#L107-L150
WDYT?
Yeah I think they are the exact events, but they have email templates and we need some copies with markup, so pls don't replace them, just duplicate them.
Unfortunately no emails get sent due to Segment issues or something.. At this point we have no process for notifying the user that they need to add an update.
Does that change what you are suggesting?
Woow I thought the email is working, let me investigate it I will keep you posted about it
@mohammadranjbarz
Maybe we want to try out using the autopilot API directly to trigger the journey?
https://autopilot.docs.apiary.io/#reference/api-methods/trigger-journey
@mohammadranjbarz
Maybe we want to try out using the autopilot API directly to trigger the journey?
https://autopilot.docs.apiary.io/#reference/api-methods/trigger-journey
Yeah it can be a good idea, if we was Segment makes too much trouble and email loss ( and it's not because of our code) we can try it out
@WhyldWanderer @MoeNick @divine-comedian The job that was supposed to check project updates and send emails for reminding project owners was disabled so it was the reason that we weren't send emails.
@CarlosQ96 Now I enabled that service with PROJECT_REVOKE_SERVICE_ACTIVE=true in Production ENV so we should wait to see what happens after that, I would appreciate if you can check what happens, we should create notifications and send emails ( send Segment events), if it wasn't it can be the bug in our code logic or related notification_type config in DB , ...
Do we have an autopilot template set for each event? @divine-comedian @WhyldWanderer
Can we make sure we arent actually revoking badges at this point though?
Can we make sure we arent actually revoking badges at this point though?
Until now the job was deactivate, but from now on it should work
Until now the job was deactivate, but from now on it should work
But just for emails right? It wont actually change the status in the db?
Im scared to revoke too many badges right away... it would be nice for people to start receiving the emails so that they know they need to add an update..
And then activate the badge revoking later after the users have had a chance to get caught up on updates
Until now the job was deactivate, but from now on it should work
But just for emails right? It wont actually change the status in the db?
Im scared to revoke too many badges right away... it would be nice for people to start receiving the emails so that they know they need to add an update..
And then activate the badge revoking later after the users have had a chance to get caught up on updates
If we want not revoke badges we can change PROJECT_UPDATES_VERIFIED_REVOKE_DAYS to a big number for instance make it 1000 days, to make sure not revoke badges ( because whole checking are one package so we can't enable some of them)
Okay.. that sounds good. Lets do that at first and then we can adjust later after people have had a chance to get reminded
Thanks Mohammad
Okay.. that sounds good. Lets do that at first and then we can adjust later after people have had a chance to get reminded
Thanks Mohammad
Done.
what about DApp notification (web) @mohammadranjbarz did they get implemented?
@MoeNick The first problem is that the job doesn't work properly, so I should put more logs to can investigate now I'm kind od blid on understanding what should I do
OMG look at how many sprints we planned for it and we could not make it since Aug
Can we prioritize it @divine-comedian ?
I don't think we can prioritize it right now among the other BE projects being worked on