impact-graph icon indicating copy to clipboard operation
impact-graph copied to clipboard

impact-graph restart on env config issues

Open aminlatifi opened this issue 2 years ago • 5 comments

If a variable is missed in the config (.env file) the docker image keeps restarting

aminlatifi avatar Feb 16 '23 15:02 aminlatifi

@mhmdksh it will be by next changes on env configs

MoeNick avatar Apr 17 '23 14:04 MoeNick

Removing my self from this issue as its part of the what @mhmdksh presented this morning and probably a better solution.

CarlosQ96 avatar Aug 10 '23 15:08 CarlosQ96

@MoeNick @aminlatifi I don't see how this error is related to how things are hosted or how we check things in our pipelines. To me, this seems like an error handling issue.

Scenarios:

1. Start Command --> ENV Available? ---> YES --> App Starts Successful
2. Start Command --> ENV Available? ---> NO --> App Won't Start

However, handling ENV Errors should not be a problem when using Vault, it will help a lot tracking the missing ENVs

mhmdksh avatar Aug 12 '23 08:08 mhmdksh

Can someone update me about status of this issue? is it still valid?

MoeNick avatar Feb 06 '24 13:02 MoeNick

I added to technical debts epic, is it still valid?

MoeNick avatar Feb 06 '24 13:02 MoeNick

@MoeNick @divine-comedian There is no enough context to what this issue is about or how it can be reproduced. Also we already have an auto-restart policy for our deployments when anything wrong happens. As well as an around the clock monitoring for logs and app health.

This is mostly done by error handling and cannot be solved by us.

Please feel free to close the issue

mhmdksh avatar Jun 25 '24 09:06 mhmdksh