impact-graph icon indicating copy to clipboard operation
impact-graph copied to clipboard

Remove Admin Column that was Deprecated

Open CarlosQ96 opened this issue 2 years ago • 1 comments

We had issues with admin column as it was a string, we couldn't fetch relationships effectively.

I deprecated for new endpoints this column, and created AdminUserId column with foreign keys so we can work better with relations.

However we can remove the old "Admin" column yet. Old tests and old code that hasn't been updated still use it.

Lets remove admin column!

CarlosQ96 avatar Jan 25 '23 15:01 CarlosQ96

tagging @WhyldWanderer here to prioritise

MoeNick avatar Jun 13 '23 11:06 MoeNick

@maryjaf to test an verify It's just a code refactor but for testing it's good to test general use cases related to Admin actions like the toast notifications for givback and verified projects on owner and non owner view, also actions like editing a project from project view that's related to admin actions

RamRamez avatar May 19 '24 10:05 RamRamez

  • [x] 1- There is a problem in showing verification status in project page, "incomplete","submitted,"rejected " aren't shown correctly in project page, it seems there only two statuses , verified and not verified

for example for "Incomplete" verification status in project owner view, the status should be shown"Incomplete" and "resume verification" button , please take a look

Correct view on production image

Current View on STG image image

maryjaf avatar May 20 '24 07:05 maryjaf

  • [x] 2- There is no reason for deactivating image

maryjaf avatar May 20 '24 07:05 maryjaf

It's just a code refactor but for testing it's good to test general use cases related to Admin actions like the toast notifications for givback and verified projects on owner and non owner view, also actions like editing a project from project view that's related to admin actions

-I haven't seen any problem in project edit flow from admin panel and toast box for givback eligible or not eligible tokens in donate page

maryjaf avatar May 20 '24 08:05 maryjaf

@maryjaf - can we call this issue done then?

divine-comedian avatar May 20 '24 14:05 divine-comedian

  • [x] 2- There is no reason for deactivating image

I think it was a temporary problem, I tested and it was ok for me.

RamRamez avatar May 20 '24 14:05 RamRamez

  • [x] 1- There is a problem in showing verification status in project page, "incomplete","submitted,"rejected " aren't shown correctly in project page, it seems there only two statuses , verified and not verified

for example for "Incomplete" verification status in project owner view, the status should be shown"Incomplete" and "resume verification" button , please take a look

Correct view on production image

Current View on STG image image

I fixed this problem. My PR just got approved and I merged it. @maryjaf you can test it after the build is completed (20 minutes from now)

RamRamez avatar May 20 '24 14:05 RamRamez