impact-graph icon indicating copy to clipboard operation
impact-graph copied to clipboard

Run migration files as JS files instead of TS

Open mohammadranjbarz opened this issue 2 years ago • 9 comments

mohammadranjbarz avatar Sep 20 '22 05:09 mohammadranjbarz

@mohammadranjbarz is this solved by the PR you linked? if not, let @Meriem-BM progress on this further.

jainkrati avatar Apr 15 '24 14:04 jainkrati

@mohammadranjbarz is this solved by the PR you linked? if not, let @Meriem-BM progress on this further.

No it's not solved(I read the related PR it seems unrelated to this) but I think https://github.com/Giveth/impact-graph/issues/1481 can be a better (easier with bigger impact issue) one for Meriem, WDYT?

mohammadranjbarz avatar Apr 15 '24 14:04 mohammadranjbarz

@mohammadranjbarz pls guide Ali Ebrahmi to take this up

jainkrati avatar May 29 '24 12:05 jainkrati

Automatically

Cool, I messaged him in DM will schedule a call about this issue

mohammadranjbarz avatar May 30 '24 12:05 mohammadranjbarz

@ae2079 This lie in package.json do the job, please modify it to run migrations as JS files "db:migrate:run:production": "NODE_ENV=production npx typeorm-ts-node-commonjs migration:run -d ./src/ormconfig.ts",

mohammadranjbarz avatar Jun 02 '24 13:06 mohammadranjbarz

should this issue test from QA side? If yes please add more data

maryjaf avatar Jun 05 '24 08:06 maryjaf

@maryjaf I think it doesn't need any tests, if staging is working and no problem exists (like today's server internal error), it is ok.

ae2079 avatar Jun 05 '24 16:06 ae2079

I just merged it and successfully deployed it on staging and it seems ok

ae2079 avatar Jun 05 '24 17:06 ae2079

It seems there is an issue with running migration files in staging because of merging a PR related to this issue, And @mohammadranjbarz reverted it to fix staging migrations

ae2079 avatar Jul 15 '24 20:07 ae2079

@mohammadranjbarz is this issue still relevant?

RamRamez avatar Sep 30 '24 08:09 RamRamez

@mohammadranjbarz is this issue still relevant?

I think we can ignore this, as we had problem when @ae2079 implemented it

mohammadranjbarz avatar Oct 01 '24 11:10 mohammadranjbarz