impact-graph icon indicating copy to clipboard operation
impact-graph copied to clipboard

Stellar | Support stellar on some endpoints

Open MoeNick opened this issue 1 year ago • 12 comments

  • [x] SaveDonation
  • [x] VerificationDonation
  • [x] Filter token list
  • [x] Create project
  • [x] Add recipient address to a project
  • [x] Filter projectlist (AcceptFunds)

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

MoeNick avatar Jul 17 '24 07:07 MoeNick

  • SaveDonation
  • [ ] VerificationDonation

I couldn't complete the donation flow yet

maryjaf avatar Aug 14 '24 09:08 maryjaf

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

How can I check it ? @Meriem-BM @MoeNick

maryjaf avatar Aug 26 '24 12:08 maryjaf

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

How can I check it ? @Meriem-BM @MoeNick

Kindly reminder

maryjaf avatar Sep 01 '24 07:09 maryjaf

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

How can I check it ? @Meriem-BM @MoeNick

Kindly reminder

@maryjaf will just wait for review and will tag you on every issue

Meriem-BM avatar Sep 01 '24 07:09 Meriem-BM

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

How can I check it ? @Meriem-BM @MoeNick

I had a question about test of this part

"Also please check if saveDoantion backup service can get affected by adding a new chain or not."

maryjaf avatar Sep 02 '24 08:09 maryjaf

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

How can I check it ? @Meriem-BM @MoeNick

I had a question about test of this part

"Also please check if saveDoantion backup service can get affected by adding a new chain or not."

More context for @Meriem-BM on this: The functionality of the donation backup service is for successful donations on-chain that BE failed to save, in this case, we save them in MONGODB so we can retry verifying or saving them by impact-graph. in our case I guess as we don't load the donation modal, it won't trigger that process and it will be fine. However, we have to make sure it won't trigger for Stellar.

MoeNick avatar Sep 02 '24 09:09 MoeNick

I think for test the mechanism of donation backup service I need your help @Meriem-BM How can we produce this situation?

for example I complete donation in LOBSTR, but there is a problem in getting last status for a few hours, in this situation what is the status of donation in our dapp?

maryjaf avatar Sep 03 '24 06:09 maryjaf

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

How can I check it ? @Meriem-BM @MoeNick

I had a question about test of this part "Also please check if saveDoantion backup service can get affected by adding a new chain or not."

More context for @Meriem-BM on this: The functionality of the donation backup service is for successful donations on-chain that BE failed to save, in this case, we save them in MONGODB so we can retry verifying or saving them by impact-graph. in our case I guess as we don't load the donation modal, it won't trigger that process and it will be fine. However, we have to make sure it won't trigger for Stellar.

Hey @mohammadranjbarz if you can explain me when the backup service is triggered.

Meriem-BM avatar Sep 03 '24 09:09 Meriem-BM

@MohammadPCh usually makes it testable. :)

MoeNick avatar Sep 03 '24 09:09 MoeNick

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

based on conversation on chat I think it needs your final approvement @Meriem-BM cc: @MoeNick

maryjaf avatar Sep 04 '24 09:09 maryjaf

Also please check if saveDoantion backup service can get affected by adding a new chain or not.

based on conversation on chat I think it needs your final approvement @Meriem-BM cc: @MoeNick

I'll DM @mohammadranjbarz about this.

Meriem-BM avatar Sep 04 '24 10:09 Meriem-BM

@Meriem-BM still needs to DM @mohammadranjbarz

divine-comedian avatar Sep 23 '24 14:09 divine-comedian

1 BLOCKER - need a confirmation that the backup service when a user donates with Stellar.

@Meriem-BM and @mohammadranjbarz still need to chat

divine-comedian avatar Sep 30 '24 14:09 divine-comedian

I checked the code and I saw that the backup service isn't triggered for the Stellar chain, it's only triggered with the regular donation nodal.

Can we move it to done @maryjaf?

Meriem-BM avatar Oct 07 '24 10:10 Meriem-BM

@Meriem-BM does this require a hotfix or is it already on production?

divine-comedian avatar Oct 07 '24 13:10 divine-comedian

It's on production.

MoeNick avatar Oct 07 '24 14:10 MoeNick