impact-graph icon indicating copy to clipboard operation
impact-graph copied to clipboard

Published 20 hours ago • verified publisher icon Giveth

Migrate to ESLint

Open RamRamez opened this issue 11 months ago • 6 comments

TSLint has been deprecated for more than four years and we need to migrate to ESLint

RamRamez avatar Mar 12 '24 13:03 RamRamez

@maryjaf to test and verify No functionality has been changed in this PR and no new functions has been added. Just general testing is needed like donating, creating a project, testing AdminJS functionality, etc

RamRamez avatar Mar 18 '24 14:03 RamRamez

@maryjaf to test and verify No functionality has been changed in this PR and no new functions has been added. Just general testing is needed like donating, creating a project, testing AdminJS functionality, etc

I'm not sure this problem is related to this change or not like as below video by tapping on "preview"or "publish" the loading icon is shown for both button

https://github.com/Giveth/impact-graph/assets/111529185/d9281836-11de-40ac-a7d6-793f0c67f552

maryjaf avatar Mar 21 '24 21:03 maryjaf

@maryjaf to test and verify No functionality has been changed in this PR and no new functions has been added. Just general testing is needed like donating, creating a project, testing AdminJS functionality, etc

I'm not sure this problem is related to this change or not like as below video by tapping on "preview"or "publish" the loading icon is shown for both button

Screen.Recording.2024-03-22.at.12.39.58.AM.mov

@maryjaf No, it's not related to my PR, please create an issue for it on FE repo.

RamRamez avatar Mar 22 '24 01:03 RamRamez

Just general testing is needed like donating, creating a project, testing AdminJS functionality, etc

Thanks @RamRamez I've not seen problems in these flows on STG

maryjaf avatar Mar 22 '24 06:03 maryjaf

@maryjaf is this resolved ?

jainkrati avatar Apr 15 '24 14:04 jainkrati

Yeah I moved it to done

maryjaf avatar Apr 15 '24 15:04 maryjaf