Add new GIVbacks Eligible tokens to back-end & fetch prices

[divine-comedian]

These are some larget market cap tokens we should consider adding to the dapp, we will need to check getting the prices on the front-end as well as the back-end.

Related FE issue is here: https://github.com/Giveth/giveth-dapps-v2/issues/3615

• [ ] STETH mainnet https://www.coingecko.com/en/coins/lido-staked-ether
• [ ] RETH mainnet https://www.coingecko.com/en/coins/rocket-pool-eth
• [ ] RETH optimism https://www.coingecko.com/en/coins/rocket-pool-eth
• [ ] GNO Gnosis https://www.coingecko.com/en/coins/gnosis
• [ ] GIV on Solana https://solscan.io/token/3Xi3EhKjnKAk2KTChzybUSWcLW6eAgTHyotHH1U6sJE1
• [ ] OUSD mainnet https://www.coingecko.com/en/coins/origin-dollar
• [ ] OETH mainnet https://www.coingecko.com/en/coins/origin-ether
• [ ] OGN mainnet https://www.coingecko.com/en/coins/origin-protocol
• [x] USDGLO Arbitrum https://www.coingecko.com/en/coins/glo-dollar

[laurenluz]

Also, we had a request from a user to add the following tokens, and Griff checked them to make sure they could be GIVbacks eligible - can we include them in this effort?

✅ OUSD: https://www.coingecko.com/en/coins/origin-dollar

✅ OETH: https://www.coingecko.com/en/coins/origin-ether

✅ OGN:https://www.coingecko.com/en/coins/origin-protocol

[divine-comedian]

I think from what I understood in these changes #1238 we should be able to add them ourselves using the adminJS panel

[laurenluz]

@WhyldWanderer can you try?

[WhyldWanderer]

Yeah! As long as all of the token liquidity has been checked and green-lighted, I can see if I can do it in AdminBro...

[WhyldWanderer]

I just saw @MoeNick made a comment in the FE end issue that Mitch linked above:

Should I still continue with adding these tokens? Also, is there a list of the addresses for these tokens?.. it will help to ensure I don't add the wrong one.

[laurenluz]

maybe you can try with one of the ones I linked like OUSD - the token addresses are on coingecko is you follow the link. I'm not sure what "it's buggy" really means - so maybe just try adding it and then you can verify/contest what @MoeNick is saying?

[WhyldWanderer]

Here is the message I get in AdminBro

And here is the console:

[WhyldWanderer]

But it is still showing in the list as if it was added successfully

[WhyldWanderer]

It is also showing in the list of tokens that can be donated on Mainnet but it doesn't populate the logo correctly

[WhyldWanderer]

I will wait for feedback before trying to add any more

[laurenluz]

ahh yeah, maybe that's the buggy part @MoeNick - can you confirm?

[MoeNick]

Yeah the logo, and sometimes you add coingecko ID and prices wont be accurate due to backend did not save them. So please check also the price at the time of donation.

These was my experiences before.

@WhyldWanderer @laurenluz

[WhyldWanderer]

ah okay.. and how do I go about adding the logo @MoeNick ?

[MoeNick]

@jainkrati For adding new tokens:

• For logos it should assign to a frontend dev
• for fixing coingeckoID it should be assigned to a backend dev

I will create a seperate issue to make sure all these steps can done in Admin, but only for tokens on this issues for now, can you manage this one @jainkrati ?

[divine-comedian]

JFYI I made this issue -https://github.com/Giveth/impact-graph/issues/1130 which was related to error handling around the add token functionality in adminJS.

[GriffGreen]

Adding

• [x] USDGLO Arbitrum https://www.coingecko.com/en/coins/glo-dollar Token Address: 0x4f604735c1cf31399c6e711d5962b2b3e0225ad3

Would love to push that fast if we can!

[MoeNick]

I found a hack way to prevent the bug in Admin: 1- Add your token. 2- Ignore the error message and get back to the token page, it should be added but without coingekoID 3- Edit the record and add the coingeckoID again

I hope it helps until the bug is fixed. @WhyldWanderer CC: @GriffGreen

[divine-comedian]

@MoeNick - Is this done or still pending?

[MoeNick]

I did only GLO Dollar on Arb as Griff asked for QF round, but the bug in admin is still there. But with the above instructions, everyone can do all the above list.

If I have to do and check all of them in the above, please let me know (Im ok to manage all issues related to this. ) @divine-comedian

[divine-comedian]

@MoeNick - that would be great, I've already added all the necessary logos and add them into the dapp for the FE.

[laurenluz]

@MoeNick @divine-comedian @WhyldWanderer

Can we also add native USDC to all chains? It's missing everywhere. For example, on Celo, we show no USDC at all On Polygon, we only show the bridged USDC (not the polygon native version)

native USDC should be GIVbacks eligible

On Polygon, we only have one USDC, it's just called "USDC" and it's the bridged version.. we should have the native version (0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359), call that USDC... and call the bridged version USDC.e

[MoeNick]

I can manage it @laurenluz wull get back

[MoeNick]

I added USDC on every chain, can you take a look @laurenluz ?

[laurenluz]

The title of the token USDC.e should be "bridged USDC" not USDC POS on Polygon, imo

also there is an issue with the logos for USDC.e on Polygon.

Probably a frontend dev should check them on all chains to fix the logos? @MohammadPCh can you assign the appropriate person?

[MoeNick]

It's named USDC.e on both Polygin scan and Uniswap I will change the name to Bridged USDC but keep the symbol as USDC.e @laurenluz

[laurenluz]

you can call it USDC.e... but not USDC (POS)... 🤔 . or is that a default?

[divine-comedian]

IDK if you can add USDC.e as a valid token name in the dapp - AFAIK the way we find token images we can't handle case sensitivity and special characters @MohammadPCh might be able to correct me.

[MoeNick]

It's done you can check.

[MohammadPCh]

@divine-comedian Yes, we change all names to lower case so it's not case-sensitive! @MoeNick Is it Done?

[divine-comedian]

careful adding tokens!

We had a big error on production today because two different tokens - USDC & Bridged USDC - were saved with the same token symbol - USDC - this caused donations to not be saved by the app, let's be careful with this in the future.

fixed USDC.e on all networks and added the corrected token image, closing this one.

Any future token add requests let's open a new issue!